Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExponentialRetryAlgorithm should use the min of initialRpc and total timeout on the first attempt #2643

Closed
mutianf opened this issue Apr 16, 2024 · 0 comments · Fixed by #2641
Closed

ExponentialRetryAlgorithm should use the min of initialRpc and total timeout on the first attempt #2643

mutianf opened this issue Apr 16, 2024 · 0 comments · Fixed by #2641
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mutianf
Copy link
Contributor

mutianf commented Apr 16, 2024

Currently the first ever RPC timeout is only override in Callables.retrying when retries are disabled: https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/main/java/com/google/api/gax/rpc/Callables.java#L103. If someone only configured a total timeout and it's smaller than the default initialRpcTimeout, their first ever RPC won't respect the overall deadline, which could cause the operation takes longer than desired.
@mutianf mutianf mentioned this issue Apr 16, 2024
Merged
4 tasks
@diegomarquezp diegomarquezp added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 17, 2024
lqiu96 pushed a commit that referenced this issue Apr 18, 2024
@mutianf
fix: first attempt should use the min of RPC timeout and total timeout (
0349232 
#2641)

Thank you for opening a Pull Request! For general contributing
guidelines, please refer to [contributing
guide](https://github.com/googleapis/gapic-generator-java/blob/main/CONTRIBUTING.md)

Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [ ] Make sure to open an issue as a
[bug/issue](https://github.com/googleapis/gapic-generator-java/issues/new/choose)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #2643 ☕️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: first attempt should use the min of RPC timeout and total timeout mutianf/gapic-generator-java
2 participants
@mutianf @diegomarquezp