Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of values in gax-java/dependencies.properties to be updated upon a release #2428

Closed
suztomo opened this issue Jan 26, 2024 · 3 comments · Fixed by #3396
Closed

Some of values in gax-java/dependencies.properties to be updated upon a release #2428

suztomo opened this issue Jan 26, 2024 · 3 comments · Fixed by #3396
Assignees
@suztomo
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Jan 26, 2024 •
edited
Loading

gax-java/dependencies.properties has the versions of the libraries in this sdk-platform-java repositories. The values are not updated upon a release and thus causes discrepancies in the generated build.gradle files.

Currently the values are updated by RenovateBot after a release.

Screenshot 2024-01-26 at 4 44 17 PM

This is from @jradcliff's email "Version compatibility of GAPIC genarator output and google-cloud-shared-dependencies"

Jeff Ching shared an example configuration of src/index.ts: https://github.com/googleapis/release-please/blob/3e807972fc8d1a348cd45e32d933ada4d25d4a28/release-please-config.json#L8
@suztomo suztomo changed the title Update Some of values in gax-java/dependencies.properties to be updated upon a release Jan 26, 2024
@blakeli0
Copy link
Collaborator

Thanks @suztomo! I think they should be updated by release-please, WDYT?

@blakeli0 blakeli0 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 26, 2024
@suztomo
Copy link
Member Author

suztomo commented Jan 26, 2024

Yes, Release Please is the solution.

@blakeli0 blakeli0 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 22, 2024
@blakeli0
Copy link
Collaborator

Downgrading to P3 as we can always manually update the generated gradle files, and we may remove the dependencies.properties file as part of the hermetic build project.

@suztomo suztomo self-assigned this Nov 25, 2024
@suztomo suztomo mentioned this issue Nov 25, 2024
Merged
suztomo added a commit to suztomo/gapic-generator-java that referenced this issue Nov 25, 2024
@suztomo
chore: Release Please anontations for dependencies.properties
21026bb 
Fixes googleapis#2428

The libraries released from api-common-java, java-common-protos,
and java-iam are annotated in gax-java/dependencies.properties.
These annotations allows the version values updated at the time
of the release pull request, ensuring the generated Gradle files
to have a proper dependency set.
lqiu96 pushed a commit to lqiu96/gapic-generator-java that referenced this issue Nov 25, 2024
@suztomo @lqiu96
chore: Release Please anontations for dependencies.properties (google…
0f248d1 
…apis#3396)

Fixes googleapis#2428

The libraries released from api-common-java, java-common-protos, and
java-iam are annotated in gax-java/dependencies.properties. These
annotations allows the version values updated at the time of the release
pull request, ensuring the generated Gradle files to have a proper
dependency set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suztomo suztomo

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Release Please anontations for dependencies.properties suztomo/gapic-generator-java
2 participants
@suztomo @blakeli0