Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gax-java(windows): HttpJsonDirectServerStreamingCallableTest.testOnResponseError- getCode() #1842

Closed
github-actions bot opened this issue Jul 13, 2023 · 1 comment · Fixed by #2444
Closed

gax-java(windows): HttpJsonDirectServerStreamingCallableTest.testOnResponseError- getCode() #1842

github-actions bot opened this issue Jul 13, 2023 · 1 comment · Fixed by #2444
Assignees
@meltsufin
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@github-actions
Copy link

The build has failed : https://github.com/googleapis/gapic-generator-java/actions/runs/5538111743
@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 18, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented Sep 18, 2023

Error:

Error:  Failures: 
Error:    HttpJsonDirectServerStreamingCallableTest.testOnResponseError:271 value of: getCode()
expected: NOT_FOUND
but was : DEADLINE_EXCEEDED

@lqiu96 lqiu96 changed the title Nightly build for Java 17 on windows-2022 failed. gax-java(windows): HttpJsonDirectServerStreamingCallableTest.testOnResponseError- getCode() Sep 18, 2023
@burkedavison burkedavison mentioned this issue Oct 16, 2023
Closed
@meltsufin meltsufin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 8, 2024
@meltsufin meltsufin self-assigned this Jan 31, 2024
meltsufin added a commit that referenced this issue Jan 31, 2024
@meltsufin
test: fix flakes in HttpJsonDirectServerStreamingCallableTest
342467d 
The flakes seem to stem from parallel execution and the resulting race conditions around static member variables, particularly the `mockService`. Attempting to fix this by using a separate `mockService` for each test.

Fixes: #1905.
Fixes: #2107.
Fixes: #1876.
Fixes: #2083.
Fixes: #1842.
Fixes: #1587.
Fixes: #1684.
@meltsufin meltsufin mentioned this issue Jan 31, 2024
Merged
meltsufin added a commit that referenced this issue Feb 7, 2024
@meltsufin
test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnRespo…
3c37a60 
…nseError

* increase timeout from 2s to 30s to reduce the chance of DEADLINE_EXCEEDED before the NOT_FOUND message is received
* keep separate low timeout for the testDeadlineExceededServerStreaming test
* remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.
@meltsufin meltsufin mentioned this issue Feb 7, 2024
Merged
meltsufin added a commit that referenced this issue Feb 7, 2024
@meltsufin
Merge branch 'main' into gh-1842
32beb94
meltsufin added a commit that referenced this issue Feb 7, 2024
@meltsufin
test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnRespo…
564802b 
…nseError (#2444)

* increase timeout from 2s to 30s to reduce the chance of
DEADLINE_EXCEEDED before the NOT_FOUND message is received
* keep separate low timeout for the testDeadlineExceededServerStreaming
test
* remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.
ddixit14 pushed a commit that referenced this issue Feb 15, 2024
@meltsufin @ddixit14
test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnRespo…
7716446 
…nseError (#2444)

* increase timeout from 2s to 30s to reduce the chance of
DEADLINE_EXCEEDED before the NOT_FOUND message is received
* keep separate low timeout for the testDeadlineExceededServerStreaming
test
* remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltsufin meltsufin

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@lqiu96 @meltsufin