check Strings null or empty.

googleapis · Nov 6, 2024 · c3b93a0 · c3b93a0
1 parent 30a37c2
commit c3b93a0
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/...java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java b/...java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java
@@ -50,6 +50,7 @@
 import com.google.auth.oauth2.S2A;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.io.Files;
@@ -448,7 +449,7 @@ ChannelCredentials createMtlsToS2AChannelCredentials(
   }
 
   ChannelCredentials createPlaintextToS2AChannelCredentials(String plaintextAddress) {
-    if (plaintextAddress.isEmpty()) {
+    if (Strings.isNullOrEmpty(plaintextAddress)) {
       return null;
     }
     return S2AChannelCredentials.newBuilder(plaintextAddress, InsecureChannelCredentials.create())
@@ -459,7 +460,7 @@ ChannelCredentials createS2ASecuredChannelCredentials() {
     S2A s2aUtils = S2A.newBuilder().build();
     String plaintextAddress = s2aUtils.getPlaintextS2AAddress();
     String mtlsAddress = s2aUtils.getMtlsS2AAddress();
-    if (mtlsAddress.isEmpty()) {
+    if (Strings.isNullOrEmpty(mtlsAddress)) {
       // Fallback to plaintext connection to S2A.
       return createPlaintextToS2AChannelCredentials(plaintextAddress);
     }