Skip to content

Commit

Permalink
[ggj][codegen][test] feat: ServiceClientTest.rpcExceptionTest support…
Browse files Browse the repository at this point in the history
… for LRO, streaming (#350)

* fix!: refactor field into MethodArgument, add enum/msg flags

* feat: partial isAssignableFrom VaporRef support, enable full-name type usage

* feat: support negative numeric literals

* fix: separate resname tokenizing from class composer

* feat: add per-type default value composer

* feat: add ServiceClientTest.methodExceptionTests codegen

* feat: add rpcExceptionTest for RPCs w/o overloads, support LRO

* fix: CI merge

* feat: ServiceClientTest.rpcExceptionTest support for LRO, streaming

* fix: sorted method args
  • Loading branch information
miraleung authored Sep 26, 2020
1 parent a0d4de5 commit 151cedb
Show file tree
Hide file tree
Showing 3 changed files with 405 additions and 74 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,14 @@ public boolean isFromPackage(String pkg) {
@Override
public boolean isSupertypeOrEquals(Reference other) {
// Not handling more complex cases for VaporReference.
return equals(other);
if (!(other instanceof VaporReference)) {
return false;
}

VaporReference ref = (VaporReference) other;
return pakkage().equals(ref.pakkage())
&& plainName().equals(ref.plainName())
&& Objects.equals(enclosingClassName(), ref.enclosingClassName());
}

@Override
Expand Down
Loading

0 comments on commit 151cedb

Please sign in to comment.