Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conventionalcommit: hangs on large pull requests #5188

Closed
noahdietz opened this issue Aug 11, 2023 · 0 comments · Fixed by #5189
Closed

conventionalcommit: hangs on large pull requests #5188

noahdietz opened this issue Aug 11, 2023 · 0 comments · Fixed by #5189
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@noahdietz
Copy link
Contributor

I have a PR with 100+ commits changing 2k+ files. The conventionalcommit check is hanging and blocking the pull request (as it is required).

I was told that logs indicate every single file touched is being logged which could mean some expensive operation is freezing up the check.

cc: @bcoe
@noahdietz noahdietz added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 11, 2023
bcoe added a commit that referenced this issue Aug 11, 2023
@bcoe
fix: handle PR with greater than 100 commits
563ef76 
Fixes #5188
@bcoe bcoe mentioned this issue Aug 11, 2023
Merged
chingor13 added a commit that referenced this issue Sep 18, 2023
@bcoe @chingor13 @SurferJeffAtGoogle
fix: handle PR with greater than 100 commits (#5189)
3ffb6b2 
Fixes #5188

---------

Co-authored-by: Jeff Ching <[email protected]>
Co-authored-by: Jeffrey Rennie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle PR with greater than 100 commits googleapis/repo-automation-bots
2 participants
@chingor13 @noahdietz