Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owlbot: new post-processor image PRs should strip issue number from the PR title #3098

Closed
chingor13 opened this issue Jan 18, 2022 · 3 comments
Closed

owlbot: new post-processor image PRs should strip issue number from the PR title #3098

chingor13 opened this issue Jan 18, 2022 · 3 comments
Assignees
@chingor13
Labels
bot: owl-bot priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chingor13
Copy link
Contributor

Example PR: googleapis/release-please#1228

The commit to googleapis/synthtool that created the new image was number 1085, but when this PR is created and automerged to the repository, it references an irrelevant PR in that repo.

Ideally, we strip the PR (#1085) part from the pull request message and (nice to have) put a full link to the source pull request in the PR body.
@chingor13 chingor13 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. bot: owl-bot labels Jan 18, 2022
@SurferJeffAtGoogle
Copy link
Contributor

I think @parthea implement this for Python. Is there a flag that can be set?

@parthea
Copy link
Contributor

parthea commented Mar 29, 2022

This issue was fixed in the cloud build file for python docker/owlbot/python/cloudbuild.yaml. See googleapis/synthtool#1137. Assigning to @chingor13 to take a look.

@parthea parthea assigned chingor13 and unassigned parthea Mar 29, 2022
@chingor13
Copy link
Contributor Author

Will that strip multiple conventional commit messages though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
bot: owl-bot priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @parthea @SurferJeffAtGoogle