Release notes duplication in new PR design.

[ddixit14]

Release:please seems to be populating old release notes in the new release PR, though the versions being suggested are new.
Reference:

1. Latest release:main PR (to be released)
2. Previous release:main PR (already released)

[suztomo]

In the "Previous release:main PR (already released)" It seems the old note is gone because these release pull requests always point to https://github.com/googleapis/google-cloud-java/blob/release-please--branches--main--release-notes/release-notes.md (by design).

[ddixit14]

Yeah, this branch will be re-used to store the release notes for every release of main branch.
For more context about the issue: As you can see below, the version suggested is new but release notes are the same.

These are the release notes for previous (already released) version.

These are the release notes for the current (to-be-released) version.

[suztomo]

Nice screenshots.

[suztomo]

Log from release-please release-pr --token=$TOKEN --repo-url https://github.com/googleapis/google-cloud-java --dry-run --trace: http://gpaste/6224127928041472 (only first 574 lines) showing the suspicious messages below:

⚠ Expected 142 releases, only found 0
⚠ Missing 142 paths: gapic-libraries-bom,google-cloud-jar-parent,google-cloud-pom-parent,java-accessapproval,java-accesscontextmanager,java-aiplatform,java-analytics-admin,java-analytics-data,java-analyticshub,java-api-gateway,java-apigee-connect,java-apigee-registry,java-apikeys,java-appengine-admin,java-area120-tables,java-artifact-registry,java-asset,java-assured-workloads,java-automl,java-bare-metal-solution,java-batch,java-beyondcorp-appconnections,java-beyondcorp-appconnectors,java-beyondcorp-appgateways,java-beyondcorp-clientconnectorservices,java-beyondcorp-clientgateways,java-bigqueryconnection,java-bigquery-data-exchange,java-bigquerydatapolicy,java-bigquerydatatransfer,java-bigquerymigration,java-bigqueryreservation,java-billingbudgets,java-billing,java-binary-authorization,java-certificate-manager,java-channel,java-cloudbuild,java-cloudcommerceconsumerprocurement,java-compute,java-contact-center-insights,java-containeranalysis,java-container,java-contentwarehouse,java-datacatalog,java-dataflow,java-dataform,java-data-fusion,java-datalabeling,java-dataplex,java-dataproc-metastore,java-dataproc,java-datastream,java-debugger-client,java-deploy,java-dialogflow-cx,java-dialogflow,java-discoveryengine,java-distributedcloudedge,java-dlp,java-dms,java-dns,java-document-ai,java-domains,java-enterpriseknowledgegraph,java-errorreporting,java-essential-contacts,java-eventarc,java-eventarc-publishing,java-filestore,java-functions,java-game-servers,java-gke-backup,java-gke-connect-gateway,java-gkehub,java-gke-multi-cloud,java-grafeas,java-gsuite-addons,java-iam-admin,java-iamcredentials,java-ids,java-iot,java-kms,java-language,java-life-sciences,java-managed-identities,java-mediatranslation,java-memcache,java-monitoring-dashboards,java-monitoring,java-networkconnectivity,java-network-management,java-network-security,java-notebooks,java-notification,java-optimization,java-orchestration-airflow,java-orgpolicy,java-os-config,java-os-login,java-phishingprotection,java-policy-troubleshooter,java-private-catalog,java-profiler,java-publicca,java-recaptchaenterprise,java-recommendations-ai,java-recommender,java-redis,java-resourcemanager,java-resource-settings,java-retail,java-run,java-scheduler,java-secretmanager,java-securitycenter,java-securitycenter-settings,java-security-private-ca,java-service-control,java-servicedirectory,java-service-management,java-service-usage,java-shell,java-speech,java-storage-transfer,java-talent,java-tasks,java-texttospeech,java-tpu,java-trace,java-translate,java-video-intelligence,java-video-live-stream,java-video-stitcher,java-video-transcoder,java-vision,java-vmmigration,java-vpcaccess,java-webrisk,java-websecurityscanner,java-workflow-executions,java-workflows

⚠ Expected 142 releases, only found 0
✔ Collecting commits since all latest releases
❯ commit search depth: 500
❯ Set(0) {}
❯ Fetching merge commits on branch main with cursor: undefined
✔ PR #8680 has many files, backfilling

I will upload a full log once the command finishes.

[suztomo]

Full log: release-please.log

[suztomo]

Jeff found that it was looking for wrong tag by looking at "SNAPSHOT" versions written in .release-please-manifest.json file.

[suztomo]

I merged googleapis/google-cloud-java#8691 . Release Please does not update the release pull request: googleapis/google-cloud-java#8686

I ran the cli (release-please release-pr --token=$TOKEN --repo-url https://github.com/googleapis/google-cloud-java --dry-run --trace 2>&1 |tee /tmp/release-please.log) and here is the full log: release-please.log

I think these lines below are the improvement by removing snapshot version from .release-please-manifest.json file:

✔ Collecting release commit SHAs
❯ release search depth: 400
❯ Fetching releases with cursor undefined
❯ Found release for path java-workflows, google-cloud-workflows-v2.5.0
❯ Found release for path java-workflow-executions, google-cloud-workflow-executions-v2.5.0
❯ Found release for path java-websecurityscanner, google-cloud-websecurityscanner-v2.5.0
...

Here are suspicious parts:

...
⚠ Found release tag with component '', but not configured in manifest
⚠ Found release tag with component '', but not configured in manifest
❯ Fetching releases with cursor Y3Vyc29yOnYyOpK5MjAxNy0wMi0xNFQxMzoxMzowMC0wNTowMM4AU0Sb
⚠ Expected 142 releases, only found 141
⚠ Missing 1 paths: java-notification
❯ looking for tagName: google-cloud-notification-v0.123.20-beta
⚠ Expected 142 releases, only found 141
❯ release for path: java-workflows, version: 2.5.0, sha: b2a5f7207e9f9b2f933e75ef4fd44973a234326f

❯ release for path: gapic-libraries-bom, version: 0.2.0, sha: b2a5f7207e9f9b2f933e75ef4fd44973a234326f
✔ Collecting commits since all latest releases
❯ commit search depth: 500
❯ Set(1) { 'b2a5f7207e9f9b2f933e75ef4fd44973a234326f' }
❯ Fetching merge commits on branch main with cursor: undefined
✔ PR #8680 has many files, backfilling
❯ Backfilling file list for commit: e7742a01d98020e25d60969699f208e871bef536
❯ Found 1000 files
✔ PR #8655 has many files, backfilling

It failed:

TypeError: Cannot read properties of undefined (reading 'pullRequest')
    at MavenWorkspace.run (/usr/local/lib/node_modules/release-please/build/src/plugins/workspace.js:104:45)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Manifest.buildPullRequests (/usr/local/lib/node_modules/release-please/build/src/manifest.js:376:38)
    at async Object.handler (/usr/local/lib/node_modules/release-please/build/src/bin/release-please.js:312:34)

What is in workspace.js 104? Nothing

[suztomo]

@chingor13 Do you observe the "Cannot read properties of undefined (reading 'pullRequest')" error in #1718 (comment) if you run the latest Release Please build from main branch?