Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning strategy is ignored when used with manifest releaser #1569

Closed
richardtippl-ext90046 opened this issue Aug 11, 2022 · 0 comments · Fixed by #1572 or #1573
Closed

Versioning strategy is ignored when used with manifest releaser #1569

richardtippl-ext90046 opened this issue Aug 11, 2022 · 0 comments · Fixed by #1572 or #1573
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@richardtippl-ext90046
Copy link

I'm using release-please with the github bot configuration, because of that i'm not sure if this issue belongs here or in the bot repo.

Environment details

  • release-please version: v13.20.0

Config files

.github/release-please.yml

handleGHRelease: true
manifest: true
versioning: always-bump-patch

release-please-config.json

{
  "packages": {
    ".": {
      "release-type": "maven",
      "skip-snapshot": true
    }
  }
}

Issue description

When enabling manifest, other options configured in release-please.yml seem to be ignored. When I disable the manifest option and set releaseType to simple, version strategy is correctly set and only increments minor version.

This seems to be intended, as when using manifest configuration, configs should be in release-please-config.json.
However, the versioning configuration isn't exposed in the manifest config.

Suggested solution

Expose the versioning-strategies configuration in release-please-config.json so that it can be used with manifest configs.

For example:

{
  "packages": {
    ".": {
      "release-type": "maven",
      "skip-snapshot": true,
      "versioning": "always-bump-patch"
    }
  }
}
@richardtippl-ext90046 richardtippl-ext90046 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 11, 2022
@chingor13 chingor13 self-assigned this Aug 11, 2022
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 11, 2022
🤖 I have created a release *beep* *boop*
---


## [13.21.0](v13.20.0...v13.21.0) (2022-08-11)


### Features

* parse versioning type from the manifest config ([#1572](#1572)) ([8a7bfc1](8a7bfc1)), closes [#1569](#1569)


### Bug Fixes

* throw underlying API error when the manifest fetch commits when determining the latest released version ([#1571](#1571)) ([0944bde](0944bde))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
2 participants