fix(ruby-yoshi): don't remove PR link from changelog (#1479)

* fix(ruby-yoshi): don't remove PR link from changelog * fix failing test case * fix lint error Co-authored-by: Jeff Ching <[email protected]>
googleapis · Jun 24, 2022 · 6faaebe · 6faaebe
1 parent f3993a0
commit 6faaebe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/__snapshots__/ruby-yoshi.js b/__snapshots__/ruby-yoshi.js
@@ -8,7 +8,7 @@ exports['RubyYoshi buildReleasePullRequest returns release PR changes with semve
 #### Bug Fixes
 
 * update dependency com.google.cloud:google-cloud-spanner to v1.50.0
-* update dependency com.google.cloud:google-cloud-storage to v1.120.0
+* update dependency com.google.cloud:google-cloud-storage to v1.120.0 ([#1234](https://github.com/googleapis/ruby-test-repo/issues/1234))
 
 ---
 This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

diff --git a/src/strategies/ruby-yoshi.ts b/src/strategies/ruby-yoshi.ts
@@ -123,10 +123,7 @@ export class RubyYoshi extends BaseStrategy {
         // Remove bolded scope from change lines
         .replace(/^\* \*\*[\w-]+:\*\* /gm, '* ')
         // Remove PR and commit links from pull request title suffixes
-        .replace(
-          /( \(\[(\w+|#\d+)\]\(https:\/\/github\.com\/[^)]*\)\))+\s*$/gm,
-          ''
-        )
+        .replace(/(\(\[(\w+)\]\(https:\/\/github\.com\/[^)]*\)\))+\s*$/gm, '')
         // Standardize on h4 for change type subheaders
         .replace(/^### (Features|Bug Fixes|Documentation)$/gm, '#### $1')
         // Collapse 2 or more blank lines