feat(release-please): add default branch input option #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragmaticivan
force-pushed
the
feature/option-for-default-branch
branch
from
18a5426 to
0006e9b
Compare
bcoe
reviewed
Jan 30, 2021
| @@ -46,6 +46,48 @@ describe('release-please-action', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| it('both opens PR to a different default branch and tags GitHub releases by default', async () => { | |||
bcoe
suggested changes
Jan 30, 2021
| } | ||
| const releasePR = sinon.stub().returns(25) | ||
| const buildStatic = sinon.stub().returns({ | ||
| run: releasePR |
There was a problem hiding this comment.
Mind adding the inverse too, that confirms we default to undefined for the default branch? (at which point the default branch is currently detected).
|
@pragmaticivan thank you for the contribution, one thought about a good additional test. |
…ot provided as input
|
@bcoe just added a slight change on the test covering both. I felt it made more sense to complement the first test (default branch) as my change was a variation of the first one. |
|
@bcoe I've also added this input into the readme. Missed that part. |
bcoe
approved these changes
Jan 31, 2021
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/google-github-actions/release-please-action/issues/201