Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create output for version #41

Closed
jef opened this issue Jul 2, 2020 · 3 comments · Fixed by #43
Closed

feat: create output for version #41

jef opened this issue Jul 2, 2020 · 3 comments · Fixed by #43

Comments

@jef
Copy link
Contributor

jef commented Jul 2, 2020 •
edited
Loading

Description

It would be really handy if the action created a few outputs that would be useful for later steps like:

  • tag: 1.0.0
  • commit: 62a67966c87f04fba1944c0fe548b018864bad71
@bcoe
Copy link
Contributor

bcoe commented Jul 2, 2020

@jef this seems like it would be a pretty reasonable addition. I think we'd need to make release-please return an object with this information when run programmatically perhaps?

@jef
Copy link
Contributor Author

jef commented Jul 2, 2020

That's a good question. If release-please uses @actions/core, this could make this pretty straight forward (hopefully)!

https://github.com/actions/toolkit/tree/master/packages/core#inputsoutputs

@jef
Copy link
Contributor Author

jef commented Jul 2, 2020

Or how ever this action interacts with release-please to be able to return that information. Then run core.setOutput on that value since release-please is outside of this action's scope.

mmarchini added a commit to mmarchini/release-please-action that referenced this issue Jul 22, 2020
@mmarchini
feat: output tag name and upload url
9c5f3e6 
Fix: googleapis#8
Fix: googleapis#41
mmarchini added a commit to mmarchini/release-please-action that referenced this issue Jul 22, 2020
@mmarchini
feat: output tag name and upload url
d41ffbe 
Fix: googleapis#8
Fix: googleapis#41
mmarchini added a commit to mmarchini/release-please-action that referenced this issue Jul 23, 2020
@mmarchini
feat: output tag name and upload url
301e58b 
The tag name is useful to interact with the release on following steps,
and the upload url is useful to upload assets to the release.

Fix: googleapis#8
Fix: googleapis#41
@mmarchini mmarchini mentioned this issue Jul 23, 2020
Merged
@bcoe bcoe closed this as completed in #43 Jul 23, 2020
bcoe pushed a commit that referenced this issue Jul 23, 2020
@mmarchini
feat: output tag name and upload url (#43)
90469b0 
The tag name is useful to interact with the release on following steps,
and the upload url is useful to upload assets to the release.

Fix: #8
Fix: #41
Closed
Closed
This was referenced Aug 22, 2022
Closed
Closed
Merged
Merged
Closed
@stainless-bot stainless-bot mentioned this issue Apr 10, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: output tag name and upload url mmarchini/release-please-action
2 participants
@bcoe @jef