Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type hints to blob and bucket #1362

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

rinarakaki
Copy link

@rinarakaki rinarakaki commented Oct 11, 2024

The goal of this PR: to pass pyright google/cloud/storage/blob.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki rinarakaki requested review from a team as code owners October 11, 2024 03:45
Copy link

conventional-commit-lint-gcf bot commented Oct 11, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Oct 11, 2024
@rinarakaki rinarakaki changed the title Add typing for Blob Add typing for Blob and Bucket Oct 11, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 11, 2024
@rinarakaki rinarakaki changed the title Add typing for Blob and Bucket chore(python): add typing for Blob and Bucket Oct 11, 2024
@rinarakaki rinarakaki changed the title chore(python): add typing for Blob and Bucket chore(python): add typing Oct 11, 2024
@rinarakaki rinarakaki changed the title chore(python): add typing chore: add typing Oct 11, 2024
@rinarakaki rinarakaki changed the title chore: add typing fix: add type hints to blob and busket Oct 12, 2024
@rinarakaki rinarakaki changed the title fix: add type hints to blob and busket fix: add type hints to blob and bucket Oct 12, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 15, 2024
@andrewsg
Copy link
Contributor

Thank you for your submission, and apologies for the significant delay. We were unable to properly evaluate this for consideration because we were preparing a major overhaul and integration of dependency libraries (the 3.0 branch currently in prerelease as 3.0rc1).

We are unable to integrate this PR as-is right now as we need to prepare an overall strategy that will result in the entire library being covered, but I'd like to spend some time gathering information to prepare that strategy now. Can you tell me about your workflow on how you created this PR, how long it took, and what tools you used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants