Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in clear_lifecycle_rules function #1074

Closed
alvaro-gh opened this issue Jul 10, 2023 · 1 comment · Fixed by #1169
Closed

Typo in clear_lifecycle_rules function #1074

alvaro-gh opened this issue Jul 10, 2023 · 1 comment · Fixed by #1169
Assignees
@andrewsg
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alvaro-gh
Copy link

This is just a typo, the function name is clear_lifecyle_rules when it should be clear_lifecycle_rules. Here's the permalink:

python-storage/google/cloud/storage/bucket.py

Line 2280 in 13f6d21

def clear_lifecyle_rules(self):

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 10, 2023
@andrewsg
Copy link
Contributor

Yep, sure is. I can't believe no one commented on this in the five years this code has been live. Thank you for letting us know.

Since people may have written code that uses the misspelled function, I will recommend fixing the typo but adding an alias for the misspelling, perhaps with a DeprecatingWarning and plan to remove it in a future version (optional).

@andrewsg andrewsg added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 11, 2023
@andrewsg andrewsg self-assigned this Jul 11, 2023
@andrewsg andrewsg mentioned this issue Oct 20, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 23, 2023
@andrewsg
fix: fix typo in Bucket.clear_lifecycle_rules() (#1169)
eae9ebe 
Fixes #1074 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix typo in Bucket.clear_lifecycle_rules() googleapis/python-storage
2 participants
@andrewsg @alvaro-gh