Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing instructions #1023

Closed
samos123 opened this issue Apr 27, 2023 · 1 comment
Closed

Improve testing instructions #1023

samos123 opened this issue Apr 27, 2023 · 1 comment
Labels
api: storage Issues related to the googleapis/python-storage API.

Comments

@samos123
Copy link
Contributor

samos123 commented Apr 27, 2023

There are currently no testing instructions, so I plan to add them. Filing this is a FR for myself.

Also improve error message for this:

nox -s system-3.8
nox > Running session system-3.8
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/system-3-8
nox > Session system-3.8 skipped: Credentials must be set via environment variable.

Seems you can't use default credentials:

export GOOGLE_APPLICATION_CREDENTIALS=~/.config/gcloud/application_default_credentials.json
nox -s system-3.8
FAILED tests/system/test__signing.py::test_create_signed_resumable_upload_url_v2 - AttributeError: you need a private key to sign credentials.the credentials you are currently using <class 'google.oauth2.credentials.Credentials'> just contains a token. see https://go...
FAILED tests/system/test__signing.py::test_create_signed_resumable_upload_url_v4 - AttributeError: you need a private key to sign credentials.the credentials you are currently using <class 'google.oauth2.credentials.Credentials'> just contains a token. see https://go...
FAILED tests/system/test_bucket.py::test_bucket_acls_w_metageneration_match - google.api_core.exceptions.BadRequest: 400 GET https://storage.googleapis.com/storage/v1/b/acl-w-metageneration-match-1682623131810/acl?prettyPrint=false: Cannot get legacy ACL for a b...
FAILED tests/system/test_bucket.py::test_ubla_set_unset_preserves_acls - google.api_core.exceptions.BadRequest: 400 GET https://storage.googleapis.com/storage/v1/b/ubla-acls-1682623177994/acl?prettyPrint=false: Cannot get legacy ACL for a bucket that has un...
FAILED tests/system/test_bucket.py::test_new_bucket_created_w_inherited_pap - google.api_core.exceptions.PreconditionFailed: 412 PATCH https://storage.googleapis.com/storage/v1/b/new-w-pap-inherited-1682623181264?projection=full&prettyPrint=false: Request violat...
FAILED tests/system/test_kms_integration.py::test_blob_w_explicit_kms_key_name - google.api_core.exceptions.Forbidden: 403 POST https://storage.googleapis.com/upload/storage/v1/b/gcp-systest-kms-1682623199848/o?uploadType=multipart&kmsKeyName=projects%2Fsam-argolis...
FAILED tests/system/test_kms_integration.py::test_bucket_w_default_kms_key_name - google.api_core.exceptions.Forbidden: 403 PATCH https://storage.googleapis.com/storage/v1/b/gcp-systest-kms-1682623199848?projection=full&prettyPrint=false: Permission denied on Cloud ...
FAILED tests/system/test_kms_integration.py::test_blob_rewrite_rotate_csek_to_cmek - google.api_core.exceptions.Forbidden: 403 POST https://storage.googleapis.com/storage/v1/b/gcp-systest-kms-1682623199848/o/rotating-keys/rewriteTo/b/gcp-systest-kms-1682623199848/o/rot...
FAILED tests/system/test_kms_integration.py::test_blob_upload_w_bucket_cmek_enabled - google.api_core.exceptions.Forbidden: 403 PATCH https://storage.googleapis.com/storage/v1/b/gcp-systest-kms-1682623199848?projection=full&prettyPrint=false: Permission denied on Cloud ...
25 failed, 48 passed, 46 skipped, 135 warnings in 163.44s (0:02:43)
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Apr 27, 2023
samos123 added a commit to samos123/python-storage that referenced this issue Apr 27, 2023
andrewsg added a commit that referenced this issue Apr 28, 2023
* Improve test error message for missing credentials

See relevant issue #1023

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Andrew Gorcester <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@cojenco
Copy link
Contributor

cojenco commented Jul 20, 2023

Closed via #1024

@cojenco cojenco closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API.
Projects
None yet
Development

No branches or pull requests

2 participants