Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release #612

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 11, 2022

Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to a new protected branch v1, not main.

This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566

BEGIN_COMMIT_OVERRIDE
fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release
END_COMMIT_OVERRIDE

@busunkim96 busunkim96 requested a review from parthea March 11, 2022 00:32
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 11, 2022
@parthea parthea changed the title chore(deps): allow google-api-core v2 on v1 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.0 on v1 release Mar 14, 2022
@parthea parthea changed the title fix(deps): require google-api-core >= 1.31.5, >= 2.3.0 on v1 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release Mar 14, 2022
@busunkim96 busunkim96 marked this pull request as draft March 17, 2022 21:46
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 5, 2022
@busunkim96 busunkim96 marked this pull request as ready for review April 5, 2022 19:57
@busunkim96 busunkim96 merged commit c1c4a45 into v1 Apr 5, 2022
@busunkim96 busunkim96 deleted the v1-api-core-pin branch April 5, 2022 19:59
@busunkim96 busunkim96 added the release-please:force-run To run release-please label Apr 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 6, 2022
@busunkim96 busunkim96 added the release-please:force-run To run release-please label Apr 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 6, 2022
@busunkim96 busunkim96 added the release-please:force-run To run release-please label Apr 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 6, 2022
@busunkim96 busunkim96 added the release-please:force-run To run release-please label Apr 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants