Code

feat: exactly-once delivery support#550

Code

Merged

pradn merged 44 commits intogoogleapis:maingoogleapis/python-pubsub:mainfrom pradn:exactly-once2pradn/python-pubsub:exactly-once2Copy head branch name to clipboardMar 4, 2022

+1,837-154

Commits

Commits on Mar 1, 2022

• Exactly-once changes

  pradn

  committed
  ed5d6e5

• rename retry duration constants

  pradn

  committed
  e35de42

• add grpc-status dependency

  pradn

  committed
  23504c8

• change dep from grpc-status to grpcio-status per error message during build

  pradn

  committed
  0a33f37

• run lint formatter

  pradn

  committed
  0b6db2e

• loosen version requirement for grpcio-status dependency to fix build

  pradn

  committed
  ccbd066

• rerun formatter with new version of black to fix lint error

  pradn

  committed
  bd21fad

• Add receive_messages_with_exactly_once_subscribe sample.

  pradn

  committed
  a6ab8ef

• Return new AcknowledgeError exception type for ack/modack failures. Translate permanent GRPC errors to an error enum contained in this exception type.

  pradn

  committed
  fd73015

• Modify exactly-once subscribe sample to use new AcknowledgeError exception.

  pradn

  committed
  349de40

• Fix formatting for google/cloud/pubsub_v1/subscriber/exceptions.py

  pradn

  committed
  71cb780

• Address Mahesh's comments

  pradn

  committed
  77ce3ef

• Rename AcknowledgeErrorCode to AcknowledgeStatus bc it includes SUCCESS.

  pradn

  committed
  f6f5d8e

• Retry leasing modack failures if exactly-once is enabled. Tests haven't been updated yet, so they're failing.

  pradn

  committed
  f35573a

• Address Mahesh's comments

  pradn

  committed
  c8017f7

• Shorten use of AcknowledgeError

  pradn

  committed
  b2e9c4b

• Fix tests and code

  pradn

  committed
  21c1431

• Fix lint errors

  pradn

  committed
  08351c2

• Improved test coverage.

  pradn

  committed
  7ba40e1

• Improve coverage.

  pradn

  committed
  94aa54c

• improve coverage for streaming_pull_manager

  pradn

  committed
  97fc72c

• Improve code coverage

  pradn

  committed
  1220d0f

• Reformat files

  pradn

  committed
  57235b9

• More fixes

  pradn

  committed
  10f5a93

• Improve coverage

  pradn

  committed
  cdb6340

• Improve coverage

  pradn

  committed
  03c8b54

• lint

  pradn

  committed
  8099fde

• Retry on a new thread to avoid blocking the one dispatcher thread.

  pradn

  committed
  7edee1d

• Remove sample - will be pulled into separate PR.

  pradn

  committed
  6fe7bf8

• Fix type checking errors.

  pradn

  committed
  1d209c9

• Address some of Mahesh's comments

  pradn

  committed
  3facfa5

• Return AcknowledgeStatus.SUCCESS for _with_response methods if exactly-once delivery is not enabled.

  pradn

  committed
  c186713

• Get coverage to 100%

  pradn

  committed
  8fb9d56

• Add default value to new Message ctor parameter so PubSubLite code doesn't break.

  pradn

  committed
  898715b

• Complete futures when a permanent RetryError is thrown and the StreamingPull stream is being shutdown.

  pradn

  committed
  245cdfd

• Fix lint

  pradn

  committed
  b1e5d70

• Fix coverage false positive in test by ignoring it.

  pradn

  committed
  377222b

• Reword some comments with "exactly-once delivery"

  pradn

  committed
  a20d48c

• Remove debug print

  pradn

  committed
  3b390b7

• Fix coverage false positive in test by ignoring it.

  pradn

  committed
  9fa28c5

• Complete all requests, not just ones with futures

  pradn

  committed
  c4ba9c7

• Better names to reflect them applying to all reqs not just ones with futures

  pradn

  committed
  36fcab9

• Improve tests and comments

  pradn

  committed
  4158315

Commits on Mar 4, 2022

• Merge branch 'main' into exactly-once2

  pradn

  authored
  eddd267