tests: mitigate flaky snippets tests #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
plamut
changed the title
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
And now the docs, oh my. :) |
|
This |
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
|
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
anguillanneuf
approved these changes
Jun 23, 2021
| # Yet, waiting on the stream shutdown should have completed *after* | ||
| # the processing of received messages has ended. | ||
| assert msg_done_lines[-1] < shutdown_done_waiting_lines[0] | ||
| except AssertionError: # pragma: NO COVER |
There was a problem hiding this comment.
I didn't know about "pragma: NO COVER". Nice.
There was a problem hiding this comment.
Yeah, but it just shouldn't be overused. :)
This is one of the cases where it's the right tool, though, it makes the coverage check happy, since a passing test does never hit the "unhappy" path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430. (maybe)
I was not able to reproduce flakiness locally, thus this PR is a best guess.
The test failure suggests that more than three messages were received, even though we only publish 3 messages in the test. This could be due to message re-delivery or because a topic might be shared between tests.
This PR reduces the total wait time in the message callback. It used to be 5 + 5 seconds, which is just the default ACK deadline, thus reducing that to 8 seconds might help. In addition, the test now prints the log output if one of the assertions fail, which will help with debugging, should the flakiness continue.
We could also use auto retries by
flakyas a last resort, but let's see if we can fix the root cause first.(update: Yet I did this for the unrelated delete schema test, because it's quite often been flaky recently)
PR checklist: