Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: drop python 2.7 support #103

Merged
merged 26 commits into from
Aug 2, 2021
Merged

fix!: drop python 2.7 support #103

merged 26 commits into from
Aug 2, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 15, 2021

  • Drop use of 'mock' shim.
  • Drop use of 'six'.
  • Drop explicit 'u"' prefixes.
  • Drop 'pytz'.

Release-As: 2.0.0b1

Closes #102.

@tseaver tseaver requested a review from a team as a code owner June 15, 2021 20:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2021
plamut
plamut reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, just a few bits remaining - things from the comments and a few mentions of "Python 2" and "2.7" in the docs that are now obsolete, e.g in CONTRIBUTING.rst and at the end of README.

google/cloud/version.py
@@ -12,4 +12,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

__version__ = "1.7.0"
__version__ = "2.0.0b1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same process question - should this be beta or an RC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in googleapis/python-api-core#212, I think a beta is sensible for a semver-major breaking change. I'll let @crwilcox and @busunkim96 chime in on that.

tests/unit/test__helpers.py Show resolved Hide resolved
google/cloud/_testing.py Outdated Show resolved Hide resolved
tests/unit/test__helpers.py Show resolved Hide resolved
plamut
plamut reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the "Deprecated Python Versions" section in README like in other libraries?

Looks good otherwise, IMO.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 18, 2021 •
edited
Loading

@plamut Thanks for the review! fca858a updates README.rst to document last version supporting Python 2.7. 12014e2 updates CONTRIBUTING.rst to drop references to running tests under Python 2.7.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 18, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Jun 18, 2021

Marked as do not merge pending discussion over the versioning policy next week with @busunkim96, @crwilcox, et al.

@plamut
Copy link
Contributor

plamut commented Jun 18, 2021 •
edited
Loading

@tseaver 12014e2 has not been pushed yet? I can still see references to Python 2.7 in CONTRIBUTING when I pull the PR branch locally.

Edit: Ah, the owlbot commit overrode those changes. Was that added to the PR branch involuntarily?

Edit 2 The CONTRIBUTING file is tempalted and must be modified through owlbot.py to make the changes persistent.

@tseaver tseaver force-pushed the 102-drop-python-2.7 branch from 0862f04 to 85775cc Compare June 18, 2021 19:32
@tseaver
Copy link
Contributor Author

tseaver commented Jun 18, 2021

@plamut Owlbot is running in automated fashion, pushing changes to PRs. I guess we have to apply the changes to CONTRIBUTING.rst in owlbot.py via s.replace() (or else exclude it -- see 85775cc).

@parthea parthea mentioned this pull request Jun 18, 2021
Closed
@parthea parthea self-requested a review July 10, 2021 14:43
@tseaver tseaver added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2021
@tseaver tseaver added the semver: major Hint for users that this is an API breaking change. label Jul 14, 2021
@tseaver tseaver mentioned this pull request Jul 27, 2021
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Aug 1, 2021

Ugh, OwlBot is restoring the 2.7 reference in the templated `scripts/readme-gen/templates/install_deps.tmpl.rst'. See googleapis/synthtool#1173.

@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 2, 2021
@tseaver tseaver merged commit 181d706 into master Aug 2, 2021
@tseaver tseaver deleted the 102-drop-python-2.7 branch August 2, 2021 18:54
This was referenced Aug 2, 2021
Merged
Closed
busunkim96 pushed a commit that referenced this pull request Aug 18, 2021
@release-please
chore: release 2.0.0 (#133)
1205758 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.0.0](https://www.github.com/googleapis/python-cloud-core/compare/v2.0.0-b1...v2.0.0) (2021-08-18)

### ⚠ BREAKING CHANGES

* drop python 2.7 support ([#103](https://www.github.com/googleapis/python-cloud-core/issues/103)) ([181d706](https://www.github.com/googleapis/python-cloud-core/commit/181d706e5b44d9d4189c21782551ce85c720d733)), closes [#102](https://www.github.com/googleapis/python-cloud-core/issues/102)

### Miscellaneous Chores

* trigger 2.0.0 release ([#128](https://www.github.com/googleapis/python-cloud-core/issues/128)) ([aead67a](https://www.github.com/googleapis/python-cloud-core/commit/aead67a1244306d518b8ab150e143e5a29e1ab6f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@chrisrossi chrisrossi Awaiting requested review from chrisrossi

@crwilcox crwilcox Awaiting requested review from crwilcox

@jimfulton jimfulton Awaiting requested review from jimfulton

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@parthea parthea Awaiting requested review from parthea

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 2.7 support.
3 participants
@tseaver @plamut @parthea