Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make unicode characters working well in load_table_from_json #865

Merged
merged 7 commits into from
Aug 11, 2021
Merged

fix: make unicode characters working well in load_table_from_json #865

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b02269
fix: make unicode characters working well in load_table_from_json (#864)
grimmer0125 Aug 9, 2021
61f85d4
test: add unit test for load_table_from_json with unicode emoji data …
grimmer0125 Aug 10, 2021
b5f75f1
test: uddate unit test for load_table_from_json with unicode emoji da…
grimmer0125 Aug 10, 2021
c5512df
Merge branch 'master' into fix_load_table_from_json_non_ascii_issue
tswast Aug 11, 2021
2c86ebb
chore: remove unused import
tseaver Aug 11, 2021
fe449fa
Merge branch 'master' into fix_load_table_from_json_non_ascii_issue
tseaver Aug 11, 2021
a0adfbb
chore: manual blacken
tseaver Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigquery/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2762,7 +2762,7 @@ def load_table_from_json(

destination = _table_arg_to_table_ref(destination, default_project=self.project)

data_str = "\n".join(json.dumps(item) for item in json_rows)
data_str = "\n".join(json.dumps(item, ensure_ascii=False) for item in json_rows)
encoded_str = data_str.encode()
data_file = io.BytesIO(encoded_str)
return self.load_table_from_file(
Expand Down