fix: error using empty array of structs parameter #474
+711
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamut
requested review from
a team and
stephaniewang526
and removed request for
a team
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
requested changes
Jan 22, 2021
tswast
requested changes
Feb 19, 2021
| raise NotImplementedError | ||
|
|
||
|
|
||
| class ScalarQueryParameterType(_AbstractQueryParameterType): |
There was a problem hiding this comment.
I don't think we should do this in this PR, but I'm tempted to ask for an additional set of constants in google.cloud.bigquery.enums that has all the scalar types defined as objects (without name & description). I imagine that will be useful when we eventually create an "array of structs query parameter" code sample.
There was a problem hiding this comment.
Sounds reasonable, let's do it in a follow-up PR. 👍
Edit: It's actually very straightforward (if I understood it correctly, that is), thus added that in an extra commit.
Co-authored-by: Tim Swast <[email protected]>
tswast
approved these changes
Feb 24, 2021
| @@ -215,6 +216,26 @@ class SqlTypeNames(str, enum.Enum): | |||
| DATETIME = "DATETIME" | |||
|
|
|||
|
|
|||
| class SqlParameterScalarTypes: | |||
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 25, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.10.0](https://www.github.com/googleapis/python-bigquery/compare/v2.9.0...v2.10.0) (2021-02-25) ### Features * add BIGNUMERIC support ([#527](https://www.github.com/googleapis/python-bigquery/issues/527)) ([cc3394f](https://www.github.com/googleapis/python-bigquery/commit/cc3394f80934419eb00c2029bb81c92a696e7d88)) ### Bug Fixes * error using empty array of structs parameter ([#474](https://www.github.com/googleapis/python-bigquery/issues/474)) ([c1d15f4](https://www.github.com/googleapis/python-bigquery/commit/c1d15f4e5da4b7e10c00afffd59a5c7f3ded027a)) * QueryJob.exception() *returns* the errors, not raises them ([#467](https://www.github.com/googleapis/python-bigquery/issues/467)) ([d763279](https://www.github.com/googleapis/python-bigquery/commit/d7632799769248b09a8558ba18f5025ebdd9675a)) ### Documentation * **bigquery:** Add alternative approach to setting credentials ([#517](https://www.github.com/googleapis/python-bigquery/issues/517)) ([60fbf28](https://www.github.com/googleapis/python-bigquery/commit/60fbf287b0d34d5db2e61cce7a5b42735ed43d0e)) * explain retry behavior for DONE jobs ([#532](https://www.github.com/googleapis/python-bigquery/issues/532)) ([696c443](https://www.github.com/googleapis/python-bigquery/commit/696c443f0a6740be0767e12b706a7771bc1460c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463.
This PR adds an optional type info parameter to
ArrayQueryParameterso that array query parameters with STRUCT items can be used in queries even if they are empty. This is a solution similar to the one used in e.g. the Ruby client.(for non-struct items the type can always be determined by using the
array_typeargument)PR checklist: