Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update the results of test based on change to hacker news data #1949

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Jun 12, 2024

Several tests were failing. presubmit testing. This PR updates the expected results to match the fetched results.

The reason for the problem is because we updated the online version of the hacker-news data dump and the data changed slightly. This now matches the data dump.

@chalmerlowe chalmerlowe requested review from a team as code owners June 12, 2024 17:40
@chalmerlowe chalmerlowe requested a review from PhongChuong June 12, 2024 17:40
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jun 12, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 12, 2024
@Linchin Linchin assigned Linchin and unassigned obada-ab Jun 12, 2024
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the sys test!

@Linchin Linchin enabled auto-merge (squash) June 12, 2024 23:42
@Linchin Linchin merged commit 19bef8d into main Jun 12, 2024
21 checks passed
@Linchin Linchin deleted the clowe-hacker-news-update branch June 12, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants