Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix pandas tests with new bqstorage client #1113

Merged
merged 4 commits into from
Jan 19, 2022
Merged

test: fix pandas tests with new bqstorage client #1113

merged 4 commits into from
Jan 19, 2022

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jan 14, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1110 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 14, 2022
@tswast tswast changed the title wip: attempt to fix pandas tests with new bqstorage client test: fix pandas tests with new bqstorage client Jan 18, 2022
@tswast tswast marked this pull request as ready for review January 18, 2022 18:20
@tswast tswast requested a review from a team January 18, 2022 18:20
@tswast tswast requested a review from a team as a code owner January 18, 2022 18:20
@tswast tswast requested a review from steffnay January 18, 2022 18:20
@tswast tswast merged commit dd40c24 into v3 Jan 19, 2022
@tswast tswast deleted the issue1110-bqstorage-refactor branch January 19, 2022 20:15
@tswast tswast mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffnay steffnay steffnay approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @steffnay