Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Ambiguity For 'google.cloud.bigquery.tests.unit.helpers' #1168

Closed
waltaskew opened this issue Mar 16, 2022 · 0 comments · Fixed by #1169
Closed

Import Ambiguity For 'google.cloud.bigquery.tests.unit.helpers' #1168

waltaskew opened this issue Mar 16, 2022 · 0 comments · Fixed by #1169
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@waltaskew
Copy link
Contributor

I'm getting an error when trying to run the test suite:

ImportError: cannot import name 'make_client' from 'google.cloud.bigquery.tests.unit.helpers'

I think this is due to some ambiguity between the tests/unit/helpers package and the tests/unit/helpers.py module
I'm not sure why it's choosing a different import in my environment than nox's.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 16, 2022
@waltaskew waltaskew mentioned this issue Mar 16, 2022
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 17, 2022
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 22, 2022
@waltaskew
test: Move tests/unit/helpers to tests/unit/_helpers (#1169)
d7f3e8d 
Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.

Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.

Fixes #1168 🦕
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this issue Apr 17, 2023
@waltaskew @abdelmegahedgoogle
test: Move tests/unit/helpers to tests/unit/_helpers (googleapis#1169)
025a904 
Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.

Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.

Fixes googleapis#1168 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Move tests/unit/helpers to tests/unit/_helpers waltaskew/python-bigquery
2 participants
@waltaskew @yoshi-automation