-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Account Impersonation #906
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
3c8c4c8
to
cb97c3e
Compare
…ot supported by ADC
@chalmerlowe @Linchin For your context when reviewing this feature request, here is the discussion the last time we considered adding this feature: #28 |
Hi @lihan, thank you for your contribution, we appreciate it. There are a few things:
Feel free to let us know if you need any more info or help! We're glad to work with you. |
@@ -89,6 +91,7 @@ def test_basic(url_with_everything): | |||
assert credentials_base64 == "eyJrZXkiOiJ2YWx1ZSJ9Cg==" | |||
assert isinstance(job_config, QueryJobConfig) | |||
assert user_supplied_client | |||
assert with_subject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: assert the exact value, instead of Boolean value
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Added service account impersonation feature.
Required service account setup:
https://developers.google.com/identity/protocols/oauth2/service-account#delegatingauthority