Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Account Impersonation #906

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lihan
Copy link

@lihan lihan commented Sep 26, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Added service account impersonation feature.

Required service account setup:
https://developers.google.com/identity/protocols/oauth2/service-account#delegatingauthority

@lihan lihan requested review from a team as code owners September 26, 2023 07:26
@lihan lihan requested a review from tswast September 26, 2023 07:26
@google-cla
Copy link

google-cla bot commented Sep 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Sep 26, 2023
@tswast tswast requested review from chalmerlowe and removed request for tswast October 4, 2023 14:53
@tswast
Copy link
Collaborator

tswast commented Dec 19, 2023

@chalmerlowe @Linchin For your context when reviewing this feature request, here is the discussion the last time we considered adding this feature: #28

@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2023
@Linchin
Copy link
Contributor

Linchin commented Jan 17, 2024

Hi @lihan, thank you for your contribution, we appreciate it. There are a few things:

  1. Could you please allow repo maintainers to change the PR, as described in this doc? Thus we can merge updates in main into your branch, or make necessary changes.
  2. At the bottom of the page you can see the presubmit tests results. One of them called "conventionalcommits.org" did not pass, as we require the first commit of the PR to follow the same conventional commits requirements. You can change the commit message by an interactive rebase, and then force push to this branch. I know this may be a lot of info, so please let me know if you need more details.
  3. I see that you have updated unit tests for parse_url() and it's great! Similarly, could you also add unit tests for the helper function and client code? We usually require 100% unit test coverage.

Feel free to let us know if you need any more info or help! We're glad to work with you.

@@ -89,6 +91,7 @@ def test_basic(url_with_everything):
assert credentials_base64 == "eyJrZXkiOiJ2YWx1ZSJ9Cg=="
assert isinstance(job_config, QueryJobConfig)
assert user_supplied_client
assert with_subject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: assert the exact value, instead of Boolean value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants