-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-60: Implement get_view_names() #62
ISSUE-60: Implement get_view_names() #62
Conversation
Makes sense, but does Superset call |
Interesting: https://docs.sqlalchemy.org/en/13/core/reflection.html#sqlalchemy.engine.reflection.Inspector.get_table_names
|
|
||
result = [] | ||
for dataset in datasets: | ||
if current_schema is not None and current_schema != dataset.dataset_id: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to call list_datasets
at all if current_schema
is set?
Edit: I see this was already-existing logic, just moved. Won't block the PR on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Thank you for adding tests as well.
Thanks! And for the record this is a backward incompatible change, so good to be explicit in the release notes |
@romainr Good point. I've updated the CHANGELOG and release notes. |
Issue: #60
Major change: in this change
get_table_names
will return only table names (without view names).