fix!: to_gbq loads unit8 columns to BigQuery INT64 instead of STRING
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix!: `to_gbq` loads naive (no timezone) columns to BigQuery DATETIME instead of TIMESTAMP fix!: `to_gbq` loads object column containing bool values to BOOLEAN instead of STRING fix!: `to_gbq` loads object column containing dictionary values to STRUCT instead of STRING
product-auto-label
bot
added
size: xl
4 tasks
tswast
requested review from
chelsea-lin and
Linchin
and removed request for
farhan0102
Looks like I need to update the tests to be compatible with older pandas. |
…_gbq' into b323176126-issue300-streaming-to_gbq
gcf-owl-bot
bot
removed
the
owlbot:run
|
@Linchin @chelsea-lin please take a look. I got it working on Python 3.8 by upgrading the minimum pyarrow version from 3.0.0 (January 2021) to 4.0.0 (April 2021). |
chelsea-lin
approved these changes
Sep 23, 2024
| @@ -0,0 +1,156 @@ | |||
| # Copyright (c) 2019 pandas-gbq Authors All rights reserved. | |||
There was a problem hiding this comment.
This contains some code I copied from a file dated to 2019, so I don't think I should update this.
gcf-owl-bot
bot
removed
the
owlbot:run
tswast
commented
Oct 21, 2024
| @@ -1219,9 +1220,16 @@ def _generate_bq_schema(df, default_type="STRING"): | |||
| be overridden: https://github.com/pydata/pandas-gbq/issues/218, this | |||
| method can be removed after there is time to migrate away from this | |||
| method.""" | |||
| from pandas_gbq import schema | |||
| fields = pandas_gbq.schema.pandas_to_bigquery.dataframe_to_bigquery_fields( | |||
There was a problem hiding this comment.
Maybe should have un-deprecated generate_bq_schema for use in bigframes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix!:
to_gbqloadsunit8columns to BigQuery INT64 instead of STRING (#814)fix!:
to_gbqloads naive (no timezone) columns to BigQuery DATETIME instead of TIMESTAMP (#814)fix!:
to_gbqloads object column containing bool values to BOOLEAN instead of STRING (#814)fix!:
to_gbqloads object column containing dictionary values to STRUCT instead of STRING (#814)deps: min pyarrow is now 4.0.0 to support compliant nested types (#814)
Release-As: 0.24.0
Note to Googlers, this copies some pandas -> BigQuery logic from both https://github.com/googleapis/python-bigquery and https://github.com/googleapis/python-bigquery-dataframes as part of an effort to reduce redundancy across code bases. My intention is to make those packages depend on pandas-gbq for pandas -> BigQuery logic.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #452, #105, #616, #450
🦕