Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up code that displays versions used in testing for debug purposes #776

Closed
wants to merge 1 commit into from
Closed

fix: clean up code that displays versions used in testing for debug purposes #776

wants to merge 1 commit into from

Conversation

chalmerlowe
Copy link
Collaborator

Cleaned up several items in the noxfile to faciliate debugging.

  • Due to additions of python -m pip freeze commands, removed several package-specific version display expressions since they are now redundant.
  • Removed a duplicative line with python -m pip freeze

@chalmerlowe chalmerlowe requested review from a team as code owners May 28, 2024 17:43
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 28, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label May 28, 2024
@chalmerlowe chalmerlowe changed the title specify a particular version of bigquery to debug fix: specify a particular version of bigquery to debug May 28, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented May 28, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@chalmerlowe chalmerlowe changed the title fix: specify a particular version of bigquery to debug fix: clean up code that displays versions used in testing for debug purposes May 28, 2024
@Linchin
Copy link
Contributor

Linchin commented May 28, 2024 •
edited
Loading

BLOCKER:
Thank you, why are we pinning google-cloud-bigquery for the pre-release test? Also the change doesn't seem to match the description.

@chalmerlowe
Copy link
Collaborator Author

BLOCKER: Thank you, why are we pinning google-cloud-bigquery for the pre-release test? Also the change doesn't seem to match the description.

Yeah. this is broken.
Gonna close this PR entirely.

@chalmerlowe chalmerlowe deleted the revise-noxfile-debug branch May 28, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrawal-siddharth agrawal-siddharth Awaiting requested review from agrawal-siddharth agrawal-siddharth is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@Linchin Linchin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalmerlowe @Linchin