Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

test(python): use constraints files to check dependency lower bounds #56

Merged
merged 6 commits into from
Apr 7, 2021

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/f050d388-263d-47cb-a29d-8bc73a06bf90/targets

  • To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Source-Link: googleapis/synthtool@86ed43d
Source-Link: googleapis/synthtool@f5c5904

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pycqa/flake8](https://gitlab.com/pycqa/flake8) | repository | minor | `3.8.4` -> `3.9.0` |

---

### Release Notes

<details>
<summary>pycqa/flake8</summary>

### [`v3.9.0`](https://gitlab.com/pycqa/flake8/compare/3.8.4...3.9.0)

[Compare Source](https://gitlab.com/pycqa/flake8/compare/3.8.4...3.9.0)

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/synthtool).

Source-Author: WhiteSource Renovate <[email protected]>
Source-Date: Tue Mar 23 17:38:03 2021 +0100
Source-Repo: googleapis/synthtool
Source-Sha: f5c5904fb0c6aa3b3730eadf4e5a4485afc65726
Source-Link: googleapis/synthtool@f5c5904
Use a constraints file when installing dependencies for system and unit tests nox sessions.

https://pip.pypa.io/en/stable/user_guide/#constraints-files
> Constraints files are requirements files that **only control which version of a requirement is installed, not whether it is installed or not**. Their syntax and contents is nearly identical to Requirements Files. There is one key difference: Including a package in a constraints file does not trigger installation of the package.

```
testing
├── constraints-3.10.txt
├── constraints-3.11.txt
├── constraints-3.6.txt
├── constraints-3.7.txt
├── constraints-3.8.txt
└── constraints-3.9.txt
```

Going forward, one constraints file (currently 3.6) will be populated with every library requirement and extra listed in the `setup.py`. The constraints file will pin each requirement to the lower bound. This ensures that library maintainers will see test failures if they forget to update a lower bound on a dependency.

See googleapis/python-bigquery#263 for an example

Source-Author: Bu Sun Kim <[email protected]>
Source-Date: Tue Mar 23 10:52:02 2021 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 86ed43d4f56e6404d068e62e497029018879c771
Source-Link: googleapis/synthtool@86ed43d
@yoshi-automation yoshi-automation requested review from a team and shollyman March 24, 2021 08:35
@product-auto-label product-auto-label bot added the api: bigqueryconnection Issues related to the googleapis/python-bigquery-connection API. label Mar 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2021
@tswast
Copy link
Contributor

tswast commented Mar 25, 2021

_ ERROR collecting tests/unit/gapic/bigquery_connection_v1/test_connection_service.py _
ImportError while importing test module '/tmpfs/src/github/python-bigquery-connection/tests/unit/gapic/bigquery_connection_v1/test_connection_service.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.6/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/unit/gapic/bigquery_connection_v1/test_connection_service.py:46: in <module>
    from google.iam.v1 import options_pb2 as options  # type: ignore
E   ImportError: cannot import name 'options_pb2'
- generated xml file: /tmpfs/src/github/python-bigquery-connection/unit_3.6_sponge_log.xml -

Looks like whereever google.iam.v1 is coming from, that package has an incorrect minimum version.

@tswast tswast changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. test(python): use constraints files to check dependency lower bounds Mar 31, 2021
@busunkim96 busunkim96 requested a review from tswast April 7, 2021 19:43
Comment on lines +43 to +45
"google-api-core >= 1.22.2, < 2.0.0dev",
"proto-plus >= 1.4.0",
"grpc-google-iam-v1",
"libcst >= 0.2.5",
"grpc-google-iam-v1 >= 0.12.3, < 0.13.0dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast I adjusted the versions for grpc-google-iam-v1 here and in the constraints.txt. PTAL. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit 95b7b62 into master Apr 7, 2021
@tswast tswast deleted the autosynth-synthtool branch April 7, 2021 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigqueryconnection Issues related to the googleapis/python-bigquery-connection API. cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants