feat: Add support for rest/ token in x-goog-api-client header
#189
Conversation
This is required for (DI)REGAPIC clients, like GCE client.
google-cla
bot
added
the
cla: yes
|
The test are failing because of missing |
| self.python_version = python_version | ||
| self.grpc_version = grpc_version | ||
| self.api_core_version = api_core_version | ||
| self.gapic_version = gapic_version | ||
| self.client_library_version = client_library_version | ||
| self.user_agent = user_agent | ||
| self.rest_version = rest_version |
There was a problem hiding this comment.
Should there be a check that either rest_version XOR grpc_version is set?
There was a problem hiding this comment.
Sounds reasonable to me, I was thinking about the same thing, but then decided that it would be safer to not add something like tha to a GA'ed library. If you feel strong about it, I can add it. Should I?
There was a problem hiding this comment.
I don't feel strongly about it, but it seems like a reasonable thing for someone looking at the fields to expect.
|
@vam-google It looks like lint is failing (everything else is passing) |
This is required for (DI)REGAPIC clients, like GCE client.