Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): added create feature and create entity type samples and tests #984

Merged
merged 25 commits into from
Feb 25, 2022
Merged

docs(samples): added create feature and create entity type samples and tests #984

merged 25 commits into from
Feb 25, 2022

Conversation

nayaknishant
Copy link
Contributor

No description provided.

@nayaknishant nayaknishant requested review from a team as code owners January 28, 2022 21:48
@nayaknishant nayaknishant requested a review from dandhlee January 28, 2022 21:48
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 28, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jan 28, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

morgandu
morgandu suggested changes Feb 1, 2022
View reviewed changes
samples/model-builder/conftest.py Outdated Show resolved Hide resolved
samples/model-builder/conftest.py Show resolved Hide resolved
samples/model-builder/test_constants.py Outdated Show resolved Hide resolved
@morgandu
Copy link
Contributor

morgandu commented Feb 1, 2022 •
edited
Loading

Left some comments throughout, please add the sync arg in relevant methods, and create a section for featurestore constant.

@morgandu morgandu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
morgandu
morgandu suggested changes Feb 24, 2022
View reviewed changes
samples/model-builder/conftest.py Outdated Show resolved Hide resolved
samples/model-builder/create_entity_type_sample.py Show resolved Hide resolved
samples/model-builder/create_feature_sample.py Show resolved Hide resolved
samples/model-builder/create_feature_sample.py Outdated Show resolved Hide resolved
samples/model-builder/create_feature_sample_test.py Show resolved Hide resolved
samples/model-builder/test_constants.py Outdated Show resolved Hide resolved
nayaknishant and others added 9 commits February 24, 2022 12:13
@nayaknishant
Merge branch 'googleapis:main' into nn-create-delete
42fffc9
@nayaknishant @morgandu
Update samples/model-builder/create_featurestore_sample_test.py
209ec83 
Co-authored-by: Morgan Du <[email protected]>
@nayaknishant @morgandu
Update samples/model-builder/test_constants.py
0c7501e 
Co-authored-by: Morgan Du <[email protected]>
@nayaknishant @morgandu
Update samples/model-builder/create_featurestore_sample_test.py
41d8fdd 
Co-authored-by: Morgan Du <[email protected]>
@nayaknishant @morgandu
docs(samples): add samples to create/delete featurestore (googleapis#980
b19fbf0 
)

* feat: SDK feature store samples (create/delete fs)

* feat: adding to conftest.py

* docs(samples): fixed testing

* docs(samples): fixed testing

* docs(samples): fixed testing

* docs(samples) added changes

* docs(samples): style issues

* Update samples/model-builder/create_featurestore_sample_test.py

Co-authored-by: Morgan Du <[email protected]>

* Update samples/model-builder/test_constants.py

Co-authored-by: Morgan Du <[email protected]>

* Update samples/model-builder/create_featurestore_sample_test.py

Co-authored-by: Morgan Du <[email protected]>

Co-authored-by: Morgan Du <[email protected]>
@nayaknishant @morgandu
Update samples/model-builder/test_constants.py
a1815fc 
Co-authored-by: Morgan Du <[email protected]>
@nayaknishant
moving constants
5c38dc2
@nayaknishant
added variables, made fixes, fixed spelling
4343293
@nayaknishant
Merge branch 'main' into nn-create-delete
56f566d
@nayaknishant nayaknishant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@morgandu
Copy link
Contributor

LGTM! Looks Good!

@nayaknishant nayaknishant merged commit d221e6b into googleapis:main Feb 25, 2022
@release-please release-please bot mentioned this pull request Feb 25, 2022
Merged
@nayaknishant nayaknishant deleted the nn-create-delete branch March 10, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgandu morgandu morgandu approved these changes

@kweinmeister kweinmeister Awaiting requested review from kweinmeister

@dandhlee dandhlee Awaiting requested review from dandhlee dandhlee was automatically assigned from googleapis/python-samples-owners

Assignees

@nayaknishant nayaknishant

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayaknishant @morgandu @yoshi-kokoro