Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable feature store batch serve to Pandas DataFrame; fix: read instances uri for batch serve #983

Merged
merged 8 commits into from
Feb 4, 2022
Merged

feat: enable feature store batch serve to Pandas DataFrame; fix: read instances uri for batch serve #983

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bcf2fc1
feat: add batch_serve_to_df, add unit tests, add integration tests; u…
morgandu Jan 28, 2022
b0b788d
Merge branch 'main' into mor--feature-store-batch-serve-to-df
morgandu Feb 1, 2022
4b03f01
fix: add self.wait() before self._parse_resource_name, add ignore_ind…
morgandu Feb 1, 2022
e7467e9
fix: setup.py versioning conflict
morgandu Feb 1, 2022
7b27082
Merge branch 'main' into mor--feature-store-batch-serve-to-df
morgandu Feb 1, 2022
c7c9c07
Merge branch 'main' into mor--feature-store-batch-serve-to-df
morgandu Feb 2, 2022
472de1e
Merge branch 'main' into mor--feature-store-batch-serve-to-df
morgandu Feb 3, 2022
290b07d
fix: optional_sync
morgandu Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions google/cloud/aiplatform/featurestore/entity_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ def __init__(
@property
def featurestore_name(self) -> str:
"""Full qualified resource name of the managed featurestore in which this EntityType is."""
self.wait()
entity_type_name_components = self._parse_resource_name(self.resource_name)
return featurestore.Featurestore._format_resource_name(
project=entity_type_name_components["project"],
Expand All @@ -150,6 +151,7 @@ def get_feature(self, feature_id: str) -> "featurestore.Feature":
Returns:
featurestore.Feature - The managed feature resource object.
"""
self.wait()
entity_type_name_components = self._parse_resource_name(self.resource_name)

return featurestore.Feature(
Expand Down Expand Up @@ -1213,6 +1215,7 @@ def ingest_from_df(
project=self.project, credentials=self.credentials
)

self.wait()
entity_type_name_components = self._parse_resource_name(self.resource_name)
featurestore_id, entity_type_id = (
entity_type_name_components["featurestore"],
Expand All @@ -1222,6 +1225,8 @@ def ingest_from_df(
temp_bq_dataset_name = f"temp_{featurestore_id}_{uuid.uuid4()}".replace(
"-", "_"
)

# TODO(b/216497263): Add support for resource project does not match initializer.global_config.project
temp_bq_dataset_id = f"{initializer.global_config.project}.{temp_bq_dataset_name}"[
:1024
]
Expand Down
2 changes: 2 additions & 0 deletions google/cloud/aiplatform/featurestore/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def __init__(
@property
def featurestore_name(self) -> str:
"""Full qualified resource name of the managed featurestore in which this Feature is."""
self.wait()
feature_path_components = self._parse_resource_name(self.resource_name)

return featurestore.Featurestore._format_resource_name(
Expand All @@ -144,6 +145,7 @@ def get_featurestore(self) -> "featurestore.Featurestore":
@property
def entity_type_name(self) -> str:
"""Full qualified resource name of the managed entityType in which this Feature is."""
self.wait()
feature_path_components = self._parse_resource_name(self.resource_name)

return featurestore.EntityType._format_resource_name(
Expand Down
Loading