Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add python 3.10 classifier #938

Closed
wants to merge 8 commits into from
Closed

Conversation

anukaal
Copy link

@anukaal anukaal commented Jan 2, 2022

added support for python 3.10

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

added support for python 3.10
@anukaal anukaal requested a review from a team as a code owner January 2, 2022 15:05
@morgandu morgandu requested a review from vinnysenthil January 5, 2022 20:22
setup.py Show resolved Hide resolved
@anukaal anukaal requested a review from a team as a code owner January 16, 2022 15:04
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2022
@parthea parthea changed the title updated classifiers chore: add python 3.10 classifier Jan 16, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 16, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 16, 2022
@parthea
Copy link
Contributor

parthea commented Jan 17, 2022

The python 3.10 is failing because the latest stable release of tensorflow 2.7.0 doesn't support python 3.10.
A pre-release version that supports python 3.10 is available: https://pypi.org/project/tensorflow/2.8.0rc0/ . Perhaps we should wait for a stable version.

nox > Running session unit-3.10
nox > Creating virtual environment (virtualenv) using python3.10 in .nox/unit-3-10
nox > python -m pip install mock asyncmock pytest pytest-cov pytest-asyncio -c /tmpfs/src/github/python-aiplatform/testing/constraints-3.10.txt
nox > python -m pip install -e '.[testing]' -c /tmpfs/src/github/python-aiplatform/testing/constraints-3.10.txt
nox > Command python -m pip install -e '.[testing]' -c /tmpfs/src/github/python-aiplatform/testing/constraints-3.10.txt failed with exit code 1:
Obtaining file:///tmpfs/src/github/python-aiplatform
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Collecting google-api-core[grpc]<3.0.0dev,>=1.26.0
  Using cached google_api_core-2.4.0-py2.py3-none-any.whl (111 kB)
Collecting proto-plus>=1.10.1
  Using cached proto_plus-1.19.8-py3-none-any.whl (45 kB)
Requirement already satisfied: packaging>=14.3 in ./.nox/unit-3-10/lib/python3.10/site-packages (from google-cloud-aiplatform==1.9.0) (21.3)
Collecting google-cloud-storage<2.0.0dev,>=1.32.0
  Using cached google_cloud_storage-1.44.0-py2.py3-none-any.whl (106 kB)
Collecting google-cloud-bigquery<3.0.0dev,>=1.15.0
  Using cached google_cloud_bigquery-2.32.0-py2.py3-none-any.whl (205 kB)
Collecting lit-nlp>=0.4.0
  Using cached lit_nlp-0.4.1-py3-none-any.whl (746 kB)
ERROR: Could not find a version that satisfies the requirement tensorflow>=2.3.0 (from google-cloud-aiplatform[testing]) (from versions: 2.8.0rc0)
ERROR: No matching distribution found for tensorflow>=2.3.0

@parthea
Copy link
Contributor

parthea commented Jan 18, 2022

FYI @vinnysenthil

@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 20, 2022
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label May 5, 2022
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 5, 2022
@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 9, 2022
@sasha-gitg sasha-gitg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 29, 2022
@sasha-gitg sasha-gitg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 30, 2022
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 15, 2022
@nayaknishant nayaknishant added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 27, 2022
@jaycee-li jaycee-li removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 27, 2022
@nayaknishant nayaknishant added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 4, 2022
@rosiezou rosiezou removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 4, 2022
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 6, 2022
@rosiezou rosiezou added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 8, 2022
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 15, 2022
@sasha-gitg
Copy link
Member

Closing in favor of #1644

@sasha-gitg sasha-gitg closed this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants