feat: Made display_name parameter optional for most calls #882

Ark-kun · 2021-12-03T05:52:13Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #853 🦕

sasha-gitg

Please add/update unit tests to test this change.

google/cloud/aiplatform/datasets/dataset.py

google/cloud/aiplatform/datasets/image_dataset.py

Ark-kun · 2022-02-03T04:08:11Z

I think I've resolved all feedback.

…ethod

Ark-kun · 2022-02-23T09:46:30Z

What are the remaining action items for me here?

vinnysenthil · 2022-02-23T15:32:50Z

Re-assigning @sasha-gitg for triage. @Ark-kun the change of argument order in public methods is considered a breaking change and cannot be merged. Some Vertex AI resources require display_name (i.e. all the Job subclasses). Please work with the team to address these issues, thanks!

Ark-kun · 2022-02-23T22:26:36Z

@Ark-kun the change of argument order in public methods is considered a breaking change and cannot be merged

Thank you for the link. I've missed this one. I'll restore the ordering. Thank you.

The parameter default values had to be removed due to Python's syntax.

google/cloud/aiplatform/datasets/dataset.py

google/cloud/aiplatform/jobs.py

google/cloud/aiplatform/training_jobs.py

…ns where default value cannot be specified

…Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997

… - Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997

…- Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997

…Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997

… - Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997

…- Simplified the component after my Vertex SDK fixes were merged Some of my Vertex SDK fixes: googleapis/python-aiplatform#779 googleapis/python-aiplatform#882 googleapis/python-aiplatform#943 googleapis/python-aiplatform#997

product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Dec 3, 2021

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2021

Ark-kun force-pushed the feat--Made-display_name-optional-for-most-calls branch from 2508d11 to ae8adcb Compare December 3, 2021 06:49

morgandu requested a review from sasha-gitg January 5, 2022 20:17

sasha-gitg requested changes Jan 19, 2022

View reviewed changes

google/cloud/aiplatform/datasets/dataset.py Show resolved Hide resolved

google/cloud/aiplatform/datasets/image_dataset.py Outdated Show resolved Hide resolved

vinnysenthil self-assigned this Jan 24, 2022

Ark-kun force-pushed the feat--Made-display_name-optional-for-most-calls branch from bf9f73f to fabb496 Compare February 3, 2022 03:35

Ark-kun requested a review from sasha-gitg February 3, 2022 04:07

Ark-kun added 7 commits February 4, 2022 18:52

feat: Made display_name optional for most calls

65224d6

Reverted the change to _Dataset.create interface

b2958ae

Extracted the display name generation to the _generate_display_name m…

b0e19fe

…ethod

Made Model.batch_predict(job_display_name=) optional

47563a0

Removed the unused imports

b3234dc

Added a unit test

c0d2aee

Fixed getting the class name.

f08c19b

Ark-kun force-pushed the feat--Made-display_name-optional-for-most-calls branch from de0b11f to f08c19b Compare February 5, 2022 02:52

Ark-kun and others added 3 commits February 6, 2022 18:00

Fixed code style

9e5a800

Fixed the unit test

1cfc9c1

Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

54c658f

vinnysenthil assigned sasha-gitg and unassigned vinnysenthil Feb 23, 2022

Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

701bbbd

Restore the parameter ordering as requested by reviewer

00977be

The parameter default values had to be removed due to Python's syntax.

Ark-kun force-pushed the feat--Made-display_name-optional-for-most-calls branch from 40dac14 to 00977be Compare March 2, 2022 10:31

Ark-kun and others added 2 commits March 2, 2022 02:41

Marked the BatchPredictJob.create job_display_name parameter as optional

8c8c8aa

Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

8e69108

Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

560b0a8

sasha-gitg requested changes Mar 7, 2022

View reviewed changes

Ark-kun added 3 commits March 7, 2022 15:14

Restored the parameter order in jobs.py as asked by reviewer

dfd164d

Added bug link to the TODO comments

93acea0

Annotated _Dataset.create(display_name) as Optional

348b51c

Ark-kun requested a review from sasha-gitg March 15, 2022 04:53

Changed docstringg as asked by the reviewer

57b1241

Ark-kun force-pushed the feat--Made-display_name-optional-for-most-calls branch from 45d8e14 to b1b19f7 Compare April 1, 2022 02:16

Implemented the reviewer request: Removed the Optional[str] annotatio…

fee7b89

…ns where default value cannot be specified

Ark-kun force-pushed the feat--Made-display_name-optional-for-most-calls branch from b1b19f7 to fee7b89 Compare April 1, 2022 02:17

Ark-kun added 2 commits March 31, 2022 19:19

Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

a695fb5

Fixed code formatting

92c1eaf

product-auto-label bot added the size: m Pull request size is medium. label Apr 1, 2022

Merge branch 'main' into feat--Made-display_name-optional-for-most-calls

3ce47f6

kweinmeister approved these changes Apr 5, 2022

View reviewed changes

sasha-gitg approved these changes Apr 5, 2022

View reviewed changes

sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Apr 5, 2022

gcf-merge-on-green bot merged commit 400b760 into googleapis:main Apr 5, 2022

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 5, 2022

release-please bot mentioned this pull request Apr 5, 2022

chore(main): release 1.12.0 #1059

Merged

release-please bot mentioned this pull request Jun 8, 2023

chore(main): release 1.24.1 #2196

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Made display_name parameter optional for most calls #882

feat: Made display_name parameter optional for most calls #882

Ark-kun commented Dec 3, 2021 •

edited

Loading

sasha-gitg left a comment

Ark-kun commented Feb 3, 2022

Ark-kun commented Feb 23, 2022

vinnysenthil commented Feb 23, 2022

Ark-kun commented Feb 23, 2022

feat: Made display_name parameter optional for most calls #882

feat: Made display_name parameter optional for most calls #882

Conversation

Ark-kun commented Dec 3, 2021 • edited Loading

sasha-gitg left a comment

Choose a reason for hiding this comment

Ark-kun commented Feb 3, 2022

Ark-kun commented Feb 23, 2022

vinnysenthil commented Feb 23, 2022

Ark-kun commented Feb 23, 2022

Ark-kun commented Dec 3, 2021 •

edited

Loading