Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: regenerate code with gapic-generator-python 1.4.4 #1779

Closed
wants to merge 6 commits into from
Closed

chore: regenerate code with gapic-generator-python 1.4.4 #1779

wants to merge 6 commits into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Nov 8, 2022

I ran the following steps to produce this PR:

  1. Create a branch in this repo
  2. Fix a replacement in owlbot.py that wasn't working properly
  3. Clone googleapis/googleapis and change the version of _gapic_generator_python_version to 1.4.4 in WORKSPACE.
  4. Run bazel build //google/cloud/aiplatform/v1:aiplatform-v1-py and bazel build //google/cloud/aiplatform/v1beta1:aiplatform-v1beta1-py
  5. In a branch for this repo, run
docker run --rm --user $(id -u):$(id -g) \
  -v $(pwd):/repo \
  -v $HOME/<PATH_TO_YOUR_>/googleapis/bazel-bin:/bazel-bin \
  gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin \
  --source-dir /bazel-bin --dest /repo
  1. In a branch for this repo, run
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Nov 8, 2022
dizcology
dizcology reviewed Nov 8, 2022
View reviewed changes
owlbot.py
@@ -129,13 +129,13 @@
s.replace(
".kokoro/samples/python3.*/common.cfg",
"""env_vars: \{
key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
Copy link
Contributor

@dizcology dizcology Nov 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added indentation seems to be why owlbot.py failed to modify common.cfg.

@dizcology
Copy link
Contributor

dizcology commented Nov 10, 2022 •
edited
Loading

Should this PR contain the code in #1760 that was recently rolled back?

@dizcology dizcology self-assigned this Nov 14, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 14, 2022
@dizcology dizcology added the ready to pull Ready to be merged into the codebase. label Nov 14, 2022
copybara-service bot pushed a commit that referenced this pull request Nov 15, 2022
@parthea @copybara-github
Copybara import of the project:
43e2805 
--
c76a319 by Anthonios Partheniou <[email protected]>:

chore: regenerate code with gapic-generator-python 1.4.4

--
9c55be3 by Yu-Han Liu <[email protected]>:

chore: regenerate with gapic-generator-python 1.4.4
COPYBARA_INTEGRATE_REVIEW=#1779 from googleapis:regenerate-code-with-gapic-1-4-4 9c55be3
PiperOrigin-RevId: 488641639
@dizcology
Copy link
Contributor

Merged at 43e2805

@dizcology dizcology closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology approved these changes

Assignees

@dizcology dizcology

Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. ready to pull Ready to be merged into the codebase. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @dizcology