-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: regenerate code with gapic-generator-python 1.4.4 #1779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizcology
reviewed
Nov 8, 2022
@@ -129,13 +129,13 @@ | |||
s.replace( | |||
".kokoro/samples/python3.*/common.cfg", | |||
"""env_vars: \{ | |||
key: "BUILD_SPECIFIC_GCLOUD_PROJECT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added indentation seems to be why owlbot.py failed to modify common.cfg.
Should this PR contain the code in #1760 that was recently rolled back? |
dizcology
approved these changes
Nov 14, 2022
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
-- c76a319 by Anthonios Partheniou <[email protected]>: chore: regenerate code with gapic-generator-python 1.4.4 -- 9c55be3 by Yu-Han Liu <[email protected]>: chore: regenerate with gapic-generator-python 1.4.4 COPYBARA_INTEGRATE_REVIEW=#1779 from googleapis:regenerate-code-with-gapic-1-4-4 9c55be3 PiperOrigin-RevId: 488641639
Merged at 43e2805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: vertex-ai
Issues related to the googleapis/python-aiplatform API.
ready to pull
Ready to be merged into the codebase.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the following steps to produce this PR:
_gapic_generator_python_version
to1.4.4
inWORKSPACE
.bazel build //google/cloud/aiplatform/v1:aiplatform-v1-py
andbazel build //google/cloud/aiplatform/v1beta1:aiplatform-v1beta1-py