Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: surface CPR docs, and reformat docstrings #1708

Merged
merged 23 commits into from
Oct 1, 2022

Conversation

kthytang
Copy link
Contributor

@kthytang kthytang commented Sep 30, 2022

Staged docs - https://cloud.devsite.corp.google.com/python/docs/reference/aiplatform/latest/google.cloud.aiplatform.prediction

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@kthytang kthytang requested review from a team as code owners September 30, 2022 02:44
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Sep 30, 2022
Copy link
Contributor

@abcdefgs0324 abcdefgs0324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

google/cloud/aiplatform/prediction/local_model.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/prediction/local_model.py Outdated Show resolved Hide resolved
@@ -376,7 +376,7 @@ def predict(
"""
if self.container_is_running is False:
raise RuntimeError(
"The local endpoint is not serving traffic. Please call `serve()`."
"The local endpoint is not serving traffic. Please call ``serve()``."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to update the unit tests if you update the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Didn't mean to modify this.

Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for working through the weird spacing issues 😓

google/cloud/aiplatform/prediction/local_model.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/prediction/local_model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rosiezou rosiezou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosiezou rosiezou added the automerge Merge the pull request once unit tests and other checks pass. label Sep 30, 2022
@nayaknishant nayaknishant added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 30, 2022
@nayaknishant nayaknishant removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 1, 2022
@nayaknishant nayaknishant merged commit 6190088 into googleapis:main Oct 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants