-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: surface CPR docs, and reformat docstrings #1708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
@@ -376,7 +376,7 @@ def predict( | |||
""" | |||
if self.container_is_running is False: | |||
raise RuntimeError( | |||
"The local endpoint is not serving traffic. Please call `serve()`." | |||
"The local endpoint is not serving traffic. Please call ``serve()``." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to update the unit tests if you update the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Didn't mean to modify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for working through the weird spacing issues 😓
Co-authored-by: Dan Lee <[email protected]>
Co-authored-by: Dan Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Staged docs - https://cloud.devsite.corp.google.com/python/docs/reference/aiplatform/latest/google.cloud.aiplatform.prediction
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕