Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: system test for model monitoring #1428

Merged
merged 7 commits into from
Jun 28, 2022
Merged

Conversation

rosiezou
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jun 14, 2022
@rosiezou rosiezou changed the title System test for model monitoring chore: system test for model monitoring Jun 14, 2022
@rosiezou rosiezou changed the base branch from main to model-monitoring June 14, 2022 02:00
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jun 14, 2022
@rosiezou rosiezou force-pushed the mm-sys-test branch 3 times, most recently from 97322c2 to db20a04 Compare June 16, 2022 01:33
@rosiezou rosiezou requested review from a team as code owners June 16, 2022 01:33
@rosiezou rosiezou requested review from dandhlee and removed request for a team June 16, 2022 01:33
@rosiezou
Copy link
Contributor Author

@dandhlee @googleapis/yoshi-python please ignore the review request for this PR. It was auto-generated due to a botched rebase which I have fixed.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 21, 2022
@rosiezou rosiezou self-assigned this Jun 26, 2022
@rosiezou
Copy link
Contributor Author

merging this branch into the parent branch for easier review

@rosiezou rosiezou closed this Jun 28, 2022
@rosiezou rosiezou reopened this Jun 28, 2022
@rosiezou rosiezou merged commit 96146ac into model-monitoring Jun 28, 2022
@rosiezou rosiezou deleted the mm-sys-test branch June 28, 2022 17:38
rosiezou added a commit that referenced this pull request Jul 28, 2022
* feat: SDK support for model monitoring (for models deployed to endpoints; batch prediction use case will be implemented separately)"

* fixing syntax errors

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* resolving merge diff

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removing sync parameter from MDM job

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fixing runtime errors

* fixing more runtime errors

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fixing some more linter errors

* added endpoint path resolution logic

* excluding uninitialized optional arguments for as_proto methods in objective config

* fixing typo in class variable

* adding more upstream error handling

* fixing errors with runtime type checks

* fixed runtime errors in update and pause functions

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removing unused methods

* fixed job delete method

* removing unused parameter

* addressing some PR comments

* docs clarification

* Update google/cloud/aiplatform/jobs.py

Co-authored-by: sasha-gitg <[email protected]>

* Update google/cloud/aiplatform/jobs.py

Co-authored-by: sasha-gitg <[email protected]>

* Update google/cloud/aiplatform/jobs.py

Co-authored-by: sasha-gitg <[email protected]>

* fixing logic for checking explanation_specs

* chore: system test for model monitoring (#1428)

* chore: adding system test for model monitoring

* debugged system test

* removing extra print statements

* added test coverage for pause resume and delete methods

* added test coverage for model monitoring config for two models

* fixing test bug

* added test coverage for XAI error case

* addressed more PR comments

* addressing remaining comments

* adding more error checking in parse_configs helper function

* minor fix for deployed model ID validation logic

* addressing docs commentes

* addressed more PR comments

* removing runtime errors

* added more documentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* addressing PR comments

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* addressing more PR comments

* adding more doc strings

* more fixes

* formatting

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* added more test coverage and changed iterator names for parse_configs function

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* making objective config class non-abstract

* renaming configuration classes

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sasha-gitg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant