Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed system test to use list_models() correctly #1397

Merged
merged 7 commits into from
May 27, 2022
Merged

fix: Changed system test to use list_models() correctly #1397

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e6a5fb4
chore: release 1.13.1
May 26, 2022
8231a9c
Merge branch 'main' of https://github.com/googleapis/python-aiplatform
May 27, 2022
083b6f1
Changed test to use list_models() correctly
May 26, 2022
916db52
feat: Changed system test to use list_models() correctly
May 26, 2022
9b3d15d
Merge branch 'goodmansam/modeluploadsystestfix' of https://github.com…
May 27, 2022
1ed564e
Merge branch 'main' into goodmansam/modeluploadsystestfix
samgoodman May 27, 2022
44e5d8b
Merge branch 'main' into goodmansam/modeluploadsystestfix
samgoodman May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/system/aiplatform/test_model_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ def test_upload_and_deploy_xgboost_model(self, shared_state):
assert model.description == "new_description"
assert model.labels == {"my_label": "updated"}

assert len(endpoint.list_models) == 1
assert len(endpoint.list_models()) == 1
endpoint.deploy(model, traffic_percentage=100)
assert len(endpoint.list_models) == 2
assert len(endpoint.list_models()) == 2
traffic_split = {
deployed_model.id: 50 for deployed_model in endpoint.list_models()
}
Expand Down