Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed dirs_exist_ok parameter as it's not backwards compatible #1170

Merged
merged 4 commits into from
Jun 23, 2022
Merged

fix: Removed dirs_exist_ok parameter as it's not backwards compatible #1170

merged 4 commits into from
Jun 23, 2022

Conversation

ivanmkc
Copy link
Contributor

@ivanmkc ivanmkc commented Apr 19, 2022 •
edited
Loading

Removed dirs_exist_ok parameter as it's not backwards compatible.

Decided to delete destination folder as it would keep the destination faithful to the source.

Fixes #1036

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 19, 2022
@ivanmkc ivanmkc force-pushed the imkc--fix-copytree-error branch from 4b07d7e to 5f550f1 Compare April 19, 2022 11:59
@sasha-gitg sasha-gitg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 20, 2022
@ivanmkc
Copy link
Contributor Author

ivanmkc commented Apr 20, 2022

I should add unit tests for this.

@ivanmkc ivanmkc changed the title Removed dirs_exist_ok parameter as it's not backwards compatible [WIP] Removed dirs_exist_ok parameter as it's not backwards compatible Apr 20, 2022
@sasha-gitg sasha-gitg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 21, 2022
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label May 5, 2022
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 5, 2022
@ivanmkc ivanmkc force-pushed the imkc--fix-copytree-error branch from 74bb8b0 to aa49312 Compare May 23, 2022 22:16
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels May 23, 2022
@ivanmkc ivanmkc changed the title [WIP] Removed dirs_exist_ok parameter as it's not backwards compatible Removed dirs_exist_ok parameter as it's not backwards compatible May 23, 2022
@ivanmkc ivanmkc force-pushed the imkc--fix-copytree-error branch from aa49312 to a3a4f04 Compare May 23, 2022 22:18
@ivanmkc ivanmkc changed the title Removed dirs_exist_ok parameter as it's not backwards compatible fix: Removed dirs_exist_ok parameter as it's not backwards compatible May 23, 2022
@ivanmkc ivanmkc force-pushed the imkc--fix-copytree-error branch from a3a4f04 to dad3781 Compare May 23, 2022 22:19
@sasha-gitg sasha-gitg added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 9, 2022
@ivanmkc ivanmkc force-pushed the imkc--fix-copytree-error branch from bcd7bc3 to 73b287b Compare June 9, 2022 23:31
@rosiezou rosiezou self-requested a review June 23, 2022 06:24
rosiezou
rosiezou approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@rosiezou rosiezou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed. LGTM

@rosiezou rosiezou merged commit 50d4129 into googleapis:main Jun 23, 2022
@release-please release-please bot mentioned this pull request Jun 23, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosiezou rosiezou rosiezou approved these changes

@kweinmeister kweinmeister Awaiting requested review from kweinmeister

@sasha-gitg sasha-gitg Awaiting requested review from sasha-gitg

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copytree's dirs_exist_ok parameter is only available in Python 3.8+
4 participants
@ivanmkc @rosiezou @sararob @sasha-gitg