Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set serving_container_command to entrypoint instead of command to match our requirements #1133

Conversation

abcdefgs0324
Copy link
Contributor

@abcdefgs0324 abcdefgs0324 requested a review from kthytang April 4, 2022 07:29
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 4, 2022
Copy link
Contributor

@kthytang kthytang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. How did this come up?

@abcdefgs0324
Copy link
Contributor Author

I found it while I was playing around.

@abcdefgs0324 abcdefgs0324 merged commit 51273bc into googleapis:custom-prediction-routine Apr 4, 2022
@abcdefgs0324 abcdefgs0324 deleted the container_command branch April 4, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants