Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ExperimentRun docstring and end_run kwarg #1649

Merged
merged 1 commit into from
Sep 7, 2022
Merged

docs: ExperimentRun docstring and end_run kwarg #1649

merged 1 commit into from
Sep 7, 2022

Conversation

jaycee-li
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@jaycee-li jaycee-li requested a review from a team as a code owner September 7, 2022 16:51
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Sep 7, 2022
@jaycee-li jaycee-li requested a review from sasha-gitg September 7, 2022 16:51
@sasha-gitg sasha-gitg changed the title fix: ExperimentRun docstring and end_run kwarg docs: ExperimentRun docstring and end_run kwarg Sep 7, 2022
@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Sep 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 075a6c2 into googleapis:main Sep 7, 2022
SinaChavoshi
SinaChavoshi approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR! lgtm.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 7, 2022
@release-please release-please bot mentioned this pull request Sep 7, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaycee-li @SinaChavoshi @sasha-gitg