Skip to content

Commit

Permalink
docs: ExperimentRun docstring and end_run kwarg (#1649)
Browse files Browse the repository at this point in the history
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-aiplatform/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
  • Loading branch information
jaycee-li authored Sep 7, 2022
1 parent dfc9578 commit 075a6c2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions google/cloud/aiplatform/metadata/experiment_run_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ def __init__(
```
Args:
run (str): Required. The name of this run.
run_name (str):
Required. The name of this run.
experiment (Union[experiment_resources.Experiment, str]):
Required. The name or instance of this experiment.
project (str):
Expand Down Expand Up @@ -1059,7 +1060,7 @@ def __exit__(self, exc_type, exc_value, traceback):
if metadata._experiment_tracker.experiment_run is self:
metadata._experiment_tracker.end_run(state=state)
else:
self.end_run(state)
self.end_run(state=state)

def end_run(
self,
Expand Down

0 comments on commit 075a6c2

Please sign in to comment.