Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the samples of hyperparameter tuning in the public doc #1600

Merged
merged 8 commits into from
Sep 6, 2022

Conversation

gericdong
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #240582178 🦕

@gericdong gericdong requested review from a team as code owners August 17, 2022 23:41
@gericdong gericdong requested a review from parthea August 17, 2022 23:41
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 17, 2022
@snippet-bot
Copy link

snippet-bot bot commented Aug 17, 2022

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. labels Aug 17, 2022
@gericdong gericdong requested a review from ivanmkc August 17, 2022 23:41
@gericdong gericdong changed the title Update the samples of hyperparameter tuning in the public doc feat: update the samples of hyperparameter tuning in the public doc Aug 22, 2022
hpt_job = aiplatform.HyperparameterTuningJob(
display_name=display_name,
custom_job=custom_job,
metric_spec={
Copy link
Contributor

@ivanmkc ivanmkc Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually pass in some of these as parameters to the function but I'm not sure how to include things like parameter specs without cluttering the parameter space with all possible parameters to CustomJob and HyperparameterTuningJob.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dizcology do you have guidance or is this okay?

},
"replica_count": 1,
"container_spec": {
"image_uri": container_uri,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems weird to pass in container_uri when it's not used in the tuning job.

@dizcology thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hptuning job creates sub jobs(trials) using the container image uri, it's actually used by the vertex hptuning jobs.

@ivanmkc
Copy link
Contributor

ivanmkc commented Aug 22, 2022

In the future, please have one PR per sample.

},
"replica_count": 1,
"container_spec": {
"image_uri": container_uri,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hptuning job creates sub jobs(trials) using the container image uri, it's actually used by the vertex hptuning jobs.

Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in for now.

We can modify the parameters later if required.

@gericdong gericdong merged commit 653b759 into googleapis:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants