fixing some more linter errors

googleapis · Jun 7, 2022 · a154c08 · a154c08
1 parent 4bba0c4
commit a154c08
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/google/cloud/aiplatform/__init__.py b/google/cloud/aiplatform/__init__.py
@@ -116,6 +116,7 @@
     "HyperparameterTuningJob",
     "Model",
     "ModelEvaluation",
+    "ModelDeploymentMonitoringJob",
     "PipelineJob",
     "TabularDataset",
     "Tensorboard",

diff --git a/google/cloud/aiplatform/jobs.py b/google/cloud/aiplatform/jobs.py
@@ -1951,7 +1951,7 @@ def __init__(
             location=location,
             credentials=credentials,
         )
-        self._gca_resource = self._get_gca_resource(resource_name=job_name)
+        self._gca_resource = self._get_gca_resource(resource_name=self.job_name)
 
     @classmethod
     def _parse_configs(
@@ -2055,7 +2055,7 @@ def _empty_constructor(
     def create(
         cls,
         display_name: str,
-        endpoint: Union[str, "models.Endpoint"],
+        endpoint: Union[str, "aiplatform.Endpoint"],
         objective_configs: Union[
             model_monitoring.EndpointObjectiveConfig,
             Dict[str, model_monitoring.EndpointObjectiveConfig],
@@ -2227,9 +2227,7 @@ def create(
         _LOGGER.log_create_with_lro(cls)
 
         if int(endpoint):
-            formatted_endpoint = (
-                f"projects/{project}/locations/{location}/endpoints/{endpoint}"
-            )
+            endpoint = f"projects/{project}/locations/{location}/endpoints/{endpoint}"
 
         gapic_mdm_job = (
             gca_model_deployment_monitoring_job.ModelDeploymentMonitoringJob(
@@ -2296,7 +2294,7 @@ def update(
     ) -> "ModelDeploymentMonitoringJob":
         """"""
         current_job = self.api_client.get_model_deployment_monitoring_job(
-            name=slef.model_deployment_monitoring_job_name
+            name=self.model_deployment_monitoring_job_name
         )
         update_mask: List[str] = []
         if display_name:

diff --git a/google/cloud/aiplatform/model_monitoring/objective.py b/google/cloud/aiplatform/model_monitoring/objective.py
@@ -107,19 +107,20 @@ def as_proto(self):
 class _ObjectiveConfig(abc.ABC):
     def __init__(
         self,
-        skew_detection_config: Optional["model_monitoring._SkewDetectionConfig"] = None,
+        skew_detection_config: Optional[
+            "gca_model_monitoring._SkewDetectionConfig"
+        ] = None,
         drift_detection_config: Optional[
-            "model_monitoring._DriftDetectionConfig"
+            "gca_model_monitoring._DriftDetectionConfig"
         ] = None,
-        explanation_config: Optional["model_monitoring._ExplanationConfig"] = None,
+        explanation_config: Optional["gca_model_monitoring._ExplanationConfig"] = None,
     ):
         self.skew_detection_config = skew_detection_config
         self.drift_detection_config = drift_detection_config
         self.explanation_config = explanation_config
 
     def as_proto(self):
         training_dataset = None
-        # print(self.skew_detection_config.target_field)
         if self.skew_detection_config is not None:
             training_dataset = (
                 gca_model_monitoring.ModelMonitoringObjectiveConfig.TrainingDataset(
@@ -136,7 +137,6 @@ def as_proto(self):
                 )
             else:
                 training_dataset.dataset = self.skew_detection_config.data_source
-            # print(training_dataset)
         return gca_model_monitoring.ModelMonitoringObjectiveConfig(
             training_dataset=training_dataset,
             training_prediction_skew_detection_config=self.skew_detection_config.as_proto(),
@@ -253,13 +253,13 @@ class EndpointObjectiveConfig(_ObjectiveConfig):
     def __init__(
         self,
         skew_detection_config: Optional[
-            "model_monitoring.EndpointSkewDetectionConfig"
+            "gca_model_monitoring.EndpointSkewDetectionConfig"
         ] = None,
         drift_detection_config: Optional[
-            "model_monitoring.EndpointDriftDetectionConfig"
+            "gca_model_monitoring.EndpointDriftDetectionConfig"
         ] = None,
         explanation_config: Optional[
-            "model_monitoring.EndpointExplanationConfig"
+            "gca_model_monitoring.EndpointExplanationConfig"
         ] = None,
     ):
         """"""