feat: add support for python 3.12 #400

parthea · 2023-10-19T15:39:18Z

Fixes #401
Fixes #402

parthea · 2023-10-19T15:51:24Z

nox > py.test -W=error --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests
ImportError while loading conftest '/home/runner/work/proto-plus-python/proto-plus-python/tests/conftest.py'.
tests/conftest.py:[18](https://github.com/googleapis/proto-plus-python/actions/runs/6577031279/job/17867761605?pr=400#step:6:19): in <module>
    from google.protobuf import descriptor_pool
.nox/unitupb-3-12/lib/python3.12/site-packages/google/protobuf/descriptor_pool.py:63: in <module>
    from google.protobuf import descriptor
.nox/unitupb-3-12/lib/python3.12/site-packages/google/protobuf/descriptor.py:40: in <module>
    from google.protobuf.internal import api_implementation
.nox/unitupb-3-12/lib/python3.12/site-packages/google/protobuf/internal/api_implementation.py:74: in <module>
    if _CanImport('google._upb._message'):
.nox/unitupb-3-12/lib/python3.12/site-packages/google/protobuf/internal/api_implementation.py:64: in _CanImport
    mod = importlib.import_module(mod_name)
E   SystemError: <class 'DeprecationWarning'> returned a result with an exception set

See related thread protocolbuffers/protobuf#12186. @ohmayr and I are looking into it.

EDIT: The reason that there is a SystemError is because we're treating warnings as errors when we run tests

proto-plus-python/noxfile.py

Line 53 in a9700cb

"-W=error",

If we remove -W=error all tests pass.

The warnings that appear are as follows:

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: Type google._upb._message.MessageMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: Type google._upb._message.ScalarMapContainer uses PyType_Spec with a metaclass that has custom tp_new. This is deprecated and will no longer be allowed in Python 3.14.

.nox/unit-3-12/lib/python3.12/site-packages/google/protobuf/internal/well_known_types.py:93
  /usr/local/google/home/partheniou/git/proto-plus-python/.nox/unit-3-12/lib/python3.12/site-packages/google/protobuf/internal/well_known_types.py:93: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    _EPOCH_DATETIME_NAIVE = datetime.datetime.utcfromtimestamp(0)

proto/datetime_helpers.py:24
  /usr/local/google/home/partheniou/git/proto-plus-python/proto/datetime_helpers.py:24: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    _UTC_EPOCH = datetime.datetime.utcfromtimestamp(0).replace(tzinfo=datetime.timezone.utc)

Filed #401 for the warning related to proto-plus. The other 3 warnings are in the protobuf code. I'll disable warnings as errors and file a bug to re-enable the -W=error flag once the warnings are fixed upstream.

…romtimestamp(0) which is deprecated

vchudnov-g · 2023-10-19T17:28:12Z

noxfile.py

@@ -49,6 +49,12 @@ def unit(session, proto="python"):
    session.install("-e", ".[testing]", "-c", constraints_path)
    if proto == "cpp":  # 4.20 does not have cpp.
        session.install("protobuf==3.19.0")
+
+    # The warnings as errors flag `-W=error` was removed in


Worth filing an issue for this, and linking it here.

Done in #403

Oh, I see. #403 is the issue tracking this. So fixing #403 MEANS re-enabling the warning.

Suggested change

# The warnings as errors flag `-W=error` was removed in

# TODO(https://github.com/googleapis/proto-plus-python/issues/403): re-enable -W=error

# The warnings-as\-errors flag `-W=error` was removed in

# https://github.com/googleapis/proto-plus-python/pull/400.

# It should be re-added once issue https://github.com/protocolbuffers/protobuf/issues/12186 is fixed.

vchudnov-g · 2023-10-19T17:31:45Z

noxfile.py

@@ -49,6 +49,12 @@ def unit(session, proto="python"):
    session.install("-e", ".[testing]", "-c", constraints_path)
    if proto == "cpp":  # 4.20 does not have cpp.
        session.install("protobuf==3.19.0")
+
+    # The warnings as errors flag `-W=error` was removed in


Oh, I see. #403 is the issue tracking this. So fixing #403 MEANS re-enabling the warning.

Suggested change

# The warnings as errors flag `-W=error` was removed in

# TODO(https://github.com/googleapis/proto-plus-python/issues/403): re-enable -W=error

# The warnings-as\-errors flag `-W=error` was removed in

# https://github.com/googleapis/proto-plus-python/pull/400.

# It should be re-added once issue https://github.com/protocolbuffers/protobuf/issues/12186 is fixed.

parthea added 4 commits October 19, 2023 11:38

feat: add support for python 3.12

78596e0

update exclude

cfbe2b2

update noxfile

8401473

add contraints file

f15707b

Disable warnings as errors

a45307e

parthea marked this pull request as ready for review October 19, 2023 16:58

parthea requested review from a team as code owners October 19, 2023 16:58

vchudnov-g approved these changes Oct 19, 2023

View reviewed changes

parthea added 2 commits October 19, 2023 17:08

use datetime.datetime.fromtimestamp instead of datetime.datetime.utcf…

9f1161c

…romtimestamp(0) which is deprecated

use datetime.timezone.utc

72c40a8

ohmayr self-requested a review October 19, 2023 17:15

ohmayr approved these changes Oct 19, 2023

View reviewed changes

vchudnov-g approved these changes Oct 19, 2023

View reviewed changes

parthea mentioned this pull request Oct 19, 2023

Re-enable warnings as errors in unit nox session #403

Open

add comment

4e673b8

vchudnov-g approved these changes Oct 19, 2023

View reviewed changes

ohmayr approved these changes Oct 19, 2023

View reviewed changes

parthea merged commit 1b3a96f into main Oct 19, 2023
26 checks passed

parthea deleted the python-312 branch October 19, 2023 17:30

release-please bot mentioned this pull request Oct 19, 2023

chore(main): release 1.23.0 #391

Merged

vchudnov-g approved these changes Oct 19, 2023

View reviewed changes

parthea mentioned this pull request Dec 4, 2023

chore(main): Release candidate v1.23.0rc2 #416

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for python 3.12 #400

feat: add support for python 3.12 #400

parthea commented Oct 19, 2023 •

edited

Loading

parthea commented Oct 19, 2023 •

edited

Loading

vchudnov-g Oct 19, 2023

parthea Oct 19, 2023

vchudnov-g Oct 19, 2023

vchudnov-g Oct 19, 2023

-    # The warnings as errors flag `-W=error` was removed in
+    # TODO(https://github.com/googleapis/proto-plus-python/issues/403): re-enable -W=error
+    # The warnings-as\-errors flag `-W=error` was removed in
+    # https://github.com/googleapis/proto-plus-python/pull/400.
+    # It should be re-added once issue https://github.com/protocolbuffers/protobuf/issues/12186 is fixed.

feat: add support for python 3.12 #400

feat: add support for python 3.12 #400

Conversation

parthea commented Oct 19, 2023 • edited Loading

parthea commented Oct 19, 2023 • edited Loading

vchudnov-g Oct 19, 2023

Choose a reason for hiding this comment

parthea Oct 19, 2023

Choose a reason for hiding this comment

vchudnov-g Oct 19, 2023

Choose a reason for hiding this comment

vchudnov-g Oct 19, 2023

Choose a reason for hiding this comment

parthea commented Oct 19, 2023 •

edited

Loading

parthea commented Oct 19, 2023 •

edited

Loading