feat: add default values parameter to to_json #164
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 862 862
Branches 149 149
=========================================
Hits 862 862
Continue to review full report at Codecov.
|
|
|
||
| json2 = Squid.to_json(s).replace(" ", "").replace("\n", "") | ||
| assert ( | ||
| json2 == '{"name":"Steve","massKg":0}' or json2 == '{"massKg":0,"name":"Steve"}' |
There was a problem hiding this comment.
Is the ordering not stable?
There was a problem hiding this comment.
No but it shouldn't matter for json objects right?
There was a problem hiding this comment.
I don't think it should matter, I just was curious if you were running into problems during testing.
software-dov
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
| instance, | ||
| *, | ||
| use_integers_for_enums=True, | ||
| including_default_value_fields=True |
There was a problem hiding this comment.
@yon-mg Could you open a follow up PR to update the docstring below?
This will result in a change in behavior for someone already using this method Protobuf defaults to False for this option. https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html#google.protobuf.json_format.MessageToJson
There was a problem hiding this comment.
I'm not sure I understand. I did not change the way google.protobuf.json_format.MessageToJson works. In fact this method message.MessageMeta.to_json should call MessageToJson in the same way as it did before if no changes are made to the additional parameter I added.
There was a problem hiding this comment.
Although I did neglect to update the docstring for this method which I will update shortly if that's what you mean.
🤖 I have created a release \*beep\* \*boop\* --- ## [1.12.0](https://www.github.com/googleapis/proto-plus-python/compare/v1.11.0...v1.12.0) (2020-11-20) ### Features * add default values parameter to to_json ([#164](https://www.github.com/googleapis/proto-plus-python/issues/164)) ([691f1b2](https://www.github.com/googleapis/proto-plus-python/commit/691f1b24454502c4ac49a88a09d1c9fbc287b2bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
No description provided.