Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additional logic to mitigate collisions with reserved terms #301

Merged
merged 6 commits into from
Feb 18, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 16, 2022

Additional fixes to mitigate collisions following PR #295

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@06d0620). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main      #301   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        22           
  Lines           ?      1002           
  Branches        ?       226           
========================================
  Hits            ?      1002           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d0620...b9b745b. Read the comment docs.

@parthea parthea force-pushed the additional-logic-to-mitigate-collisions branch from 949e811 to 7b28b29 Compare February 16, 2022 01:04
@parthea parthea force-pushed the additional-logic-to-mitigate-collisions branch from 7b28b29 to 1539d31 Compare February 16, 2022 01:11
@parthea parthea marked this pull request as ready for review February 16, 2022 01:22
@parthea parthea requested review from a team as code owners February 16, 2022 01:22
proto/message.py Outdated Show resolved Hide resolved
proto/message.py Outdated Show resolved Hide resolved
proto/message.py Outdated Show resolved Hide resolved
proto/message.py Outdated Show resolved Hide resolved
tests/test_fields_mitigate_collision.py Outdated Show resolved Hide resolved
tests/test_fields_mitigate_collision.py Outdated Show resolved Hide resolved
tests/test_fields_mitigate_collision.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look goo to me, but can we please avoid code dupliction if possible?

proto/message.py Outdated Show resolved Hide resolved
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise LGTM.

tests/test_fields_mitigate_collision.py Outdated Show resolved Hide resolved
@parthea parthea merged commit c9a77df into main Feb 18, 2022
@parthea parthea deleted the additional-logic-to-mitigate-collisions branch February 18, 2022 00:37
@chingor13 chingor13 added the release-please:force-run To run release-please label Feb 18, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Feb 18, 2022
@chingor13 chingor13 added the release-please:force-run To run release-please label Feb 18, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Feb 18, 2022
@chingor13 chingor13 added the release-please:force-run To run release-please label Feb 18, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants