-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: additional logic to mitigate collisions with reserved terms #301
Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 22
Lines ? 1002
Branches ? 226
========================================
Hits ? 1002
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
949e811
to
7b28b29
Compare
7b28b29
to
1539d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look goo to me, but can we please avoid code dupliction if possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, otherwise LGTM.
Additional fixes to mitigate collisions following PR #295