Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release-please did not open a release PR after merging to main #1305

Closed
parthea opened this issue Feb 18, 2022 · 2 comments
Closed

Release-please did not open a release PR after merging to main #1305

parthea opened this issue Feb 18, 2022 · 2 comments
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Feb 18, 2022

I merged googleapis/proto-plus-python#301 which contained a conventional commit with prefix fix: however release-please didn't open a pull request.

The specific commit which should have triggered release-please to open a PR is googleapis/proto-plus-python@c9a77df . See all commits to main here.
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 18, 2022
@parthea
Copy link
Contributor Author

parthea commented Feb 18, 2022

I'm also seeing this issue in https://github.com/googleapis/gapic-generator-python, after merging googleapis/gapic-generator-python#1210. See commit googleapis/gapic-generator-python@e895106 here .

@parthea
Copy link
Contributor Author

parthea commented Feb 18, 2022

The release PRs are now open on both repos.

@parthea parthea closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parthea