Skip to content

Commit

Permalink
docs: clarify TODO for reenabling erroring on warnings (#405)
Browse files Browse the repository at this point in the history
  • Loading branch information
vchudnov-g authored Oct 19, 2023
1 parent 73d3ee1 commit cb7b49a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ def unit(session, proto="python"):
if proto == "cpp": # 4.20 does not have cpp.
session.install("protobuf==3.19.0")

# The warnings as errors flag `-W=error` was removed in
# TODO(https://github.com/googleapis/proto-plus-python/issues/403): re-enable `-W=error`
# The warnings-as-errors flag `-W=error` was removed in
# https://github.com/googleapis/proto-plus-python/pull/400.
# It should be re-added once issue
# https://github.com/googleapis/proto-plus-python/issues/403 is fixed.
# See also https://github.com/protocolbuffers/protobuf/issues/12186.
# https://github.com/protocolbuffers/protobuf/issues/12186 is fixed.
session.run(
"py.test",
"--quiet",
Expand Down

0 comments on commit cb7b49a

Please sign in to comment.