Django samples #636

waprin · 2016-08-20T00:15:41Z

No description provided.

samples/django/README.md

+# Django Samples
+
+These two sample Django apps provide a skeleton for the two main use cases of the
+Django contrib helpers


waprin · 2016-08-23T00:27:08Z

@nathanielmanistaatgoogle responded to all comments but need to take another pass myself but have to run at this minute, will finish up later tonight. Will also stop importing functions across the samples though as discussed debatable whether it makes more sense to stick with Django conventions over oauth2client conventions.

waprin · 2016-08-23T05:24:27Z

@nathanielmanistaatgoogle ok ready for another pass, also cleaned up some unnecessary files. Following the style guide for imports does make sense to me, I think it's just the types in settings.py we should leave alone.

Whenever review is LGTM, besides needing to squash the review commits, I'd like to do a final pass on an actual server for both these samples before merge.

cloud-dpe-jenkins · 2016-08-24T00:41:07Z

Starting a new build on Jenkins!

cloud-dpe-jenkins · 2016-08-24T00:41:08Z

Build on Jenkins Started!

cloud-dpe-jenkins · 2016-08-24T00:41:12Z

Build finished. No test results found.

waprin · 2016-08-24T00:47:06Z

Sorry experimenting with Jenkins job to report system tests in background.

samples/django/django_user/requirements.txt

@@ -0,0 +1,3 @@
+Django==0.10.0


samples/django/django_user/requirements.txt

@@ -0,0 +1,3 @@
+Django==1.10.0
+oauth2client==3.0.0


nathanielmanistaatgoogle · 2016-09-03T15:19:31Z

Completed another review pass; I don't think I noticed anything beyond cosmetics.

samples/django/django_user/polls/views.py

+
+
+@decorators.oauth_required
+def get_profile_required(request):


wasabigeek · 2016-09-12T06:42:01Z

@waprin did you have the chance to take a look at the comments?

waprin · 2016-09-14T21:49:37Z

@wasabigeek was on vacation from work and programming in general, will look back around on this tonight!

Contains two sets of samples - one for the “Google auth” system and one for the “Django user auth” system.

waprin · 2016-09-19T17:13:57Z

@wasabigeek @nathanielmanistaatgoogle thanks for review comments, I addressed all the issues and tested them again, ready for review pass. Prob should wait until a release before we merge though since the samples working do depend on some of the bugfixes.

nathanielmanistaatgoogle · 2016-09-20T18:35:02Z

I'm satisfied. Who else will be reviewing this?

waprin · 2016-09-20T18:49:23Z

I think we had an oauth2client maintainer and someone who tried the samples (thanks again @wasabigeek ) so we should be good to merge. I will also at some point take a look at the google-api-python-client and see if it makes sense to redirect here which should get us more eyes. But since the samples will have known bug fixes until the next release, maybe @jonparrott wants to merge whenever next release is cut (after we update the requirements.txt)?

theacodes · 2016-09-20T19:25:14Z

@waprin the next release is cut for what? this library? What changes are needed?

waprin · 2016-09-20T19:27:31Z

@jonparrott #623 #651 #614 . Otherwise the samples are unfortunately probably too buggy to even have in the repo.

theacodes · 2016-09-20T19:28:34Z

I'm going to merge this and cut a new release.

theacodes · 2016-09-20T19:32:45Z

Actually, I can't release without bumping a major version which we wanted to reserve for the transport refactors.

@waprin where are these samples referenced?

waprin · 2016-09-20T19:33:42Z

@jonparrott they are only referenced here for now

theacodes · 2016-09-20T19:34:42Z

@waprin then I am okay with the situation for now. Let's hold off on any external references until we can release 4.0.0.

googlebot added the cla: yes label Aug 20, 2016

waprin force-pushed the django_samples branch from e204ca8 to e13c1f2 Compare August 20, 2016 00:18

nathanielmanistaatgoogle reviewed Aug 20, 2016
View reviewed changes

waprin mentioned this pull request Aug 22, 2016

Added requirements file to Django sample googleapis/google-api-python-client#268

Closed

wasabigeek reviewed Aug 24, 2016
View reviewed changes

samples/django/django_user/requirements.txt

@@ -0,0 +1,3 @@

Django==0.10.0

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

wasabigeek reviewed Sep 3, 2016
View reviewed changes

samples/django/django_user/requirements.txt

@@ -0,0 +1,3 @@

Django==1.10.0

oauth2client==3.0.0

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

wasabigeek reviewed Sep 3, 2016
View reviewed changes

samples/django/django_user/polls/views.py

@decorators.oauth_required

def get_profile_required(request):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

waprin force-pushed the django_samples branch 2 times, most recently from 9fee377 to a917acf Compare September 16, 2016 22:45

Add Django Samples

f91ddf8

Contains two sets of samples - one for the “Google auth” system and one for the “Django user auth” system.

waprin force-pushed the django_samples branch from a917acf to f91ddf8 Compare September 16, 2016 23:04

nathanielmanistaatgoogle assigned theacodes Sep 20, 2016

theacodes merged commit 3f9fdbd into googleapis:master Sep 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Django samples #636

Django samples #636

waprin commented Aug 20, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

waprin commented Aug 23, 2016

waprin commented Aug 23, 2016

cloud-dpe-jenkins commented Aug 24, 2016

cloud-dpe-jenkins commented Aug 24, 2016

cloud-dpe-jenkins commented Aug 24, 2016

waprin commented Aug 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nathanielmanistaatgoogle commented Sep 3, 2016

This comment was marked as spam.

This comment was marked as spam.

wasabigeek commented Sep 12, 2016

waprin commented Sep 14, 2016

waprin commented Sep 19, 2016 •

edited

Loading

nathanielmanistaatgoogle commented Sep 20, 2016

waprin commented Sep 20, 2016

theacodes commented Sep 20, 2016

waprin commented Sep 20, 2016

theacodes commented Sep 20, 2016

theacodes commented Sep 20, 2016

waprin commented Sep 20, 2016

theacodes commented Sep 20, 2016



		@decorators.oauth_required
		def get_profile_required(request):

Django samples #636

Django samples #636

Conversation

waprin commented Aug 20, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

waprin commented Aug 23, 2016

waprin commented Aug 23, 2016

cloud-dpe-jenkins commented Aug 24, 2016

cloud-dpe-jenkins commented Aug 24, 2016

cloud-dpe-jenkins commented Aug 24, 2016

waprin commented Aug 24, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nathanielmanistaatgoogle commented Sep 3, 2016

This comment was marked as spam.

This comment was marked as spam.

wasabigeek commented Sep 12, 2016

waprin commented Sep 14, 2016

waprin commented Sep 19, 2016 • edited Loading

nathanielmanistaatgoogle commented Sep 20, 2016

waprin commented Sep 20, 2016

theacodes commented Sep 20, 2016

waprin commented Sep 20, 2016

theacodes commented Sep 20, 2016

theacodes commented Sep 20, 2016

waprin commented Sep 20, 2016

theacodes commented Sep 20, 2016

waprin commented Sep 19, 2016 •

edited

Loading